Iterate over storage plugins #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated persons.json and made sure that it is not overwritten by any test.
…e ready using it...
lovfall
reviewed
Sep 13, 2023
| @@ -191,7 +191,7 @@ def table_create(self, meta, dims=None): | |||
| ] | |||
| for p in meta["properties"]: | |||
| decl = f'"{p.name}" {to_pgtype(p.type)}' | |||
| if len(p.dims): | |||
There was a problem hiding this comment.
This change does not make sense to me. You test for the length of shape, but use dims, as before you tested and used dims
There was a problem hiding this comment.
Sell seen. p.dims is an backward-compatible alias for p.shape. We should use p.shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed iteration over storage plugins. One use case is automatic generation of documentation of storage plugins (see issue #642).
Quite many changes, but the most interesting change is this line.
Additional fixes:
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.