Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.0 #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Release 4.0.0 #2

wants to merge 4 commits into from

Conversation

golluroSICKAG
Copy link
Contributor

Version 4.0.0

New features

  • Supports FlowConfig feature to link data provider to put data to FTP server
  • Provide version of module via 'OnNewStatusModuleVersion'
  • Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
  • Function 'getParameters' to provide PersistentData parameters
  • It is now possible to register to events to put received data (JPG or DATA) to the FTP server (see 'addRegistration')
  • Function to 'resetModule' to default setup

Improvements

  • New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
  • 'loadParameters' returns its success
  • 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
  • Changed log level of some messages from 'info' to 'fine'
  • Added UI icon and browser tab information

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

@golluroSICKAG
# Release 4.0.0
950cd72 
## New features
- Supports FlowConfig feature to link data provider to put data to FTP server
- Provide version of module via 'OnNewStatusModuleVersion'
- Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
- Function 'getParameters' to provide PersistentData parameters
- It is now possible to register to events to put received data (JPG or DATA) to the FTP server (see 'addRegistration')

## Improvements
- New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
- 'loadParameters' returns its success
- 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
- Changed log level of some messages from 'info' to 'fine'
- Added UI icon and browser tab information
@golluroSICKAG
- Minor edits in CHANGELOG
7a1d50e
@golluroSICKAG
- Update of UI settings
3fd74c3
@dzekomiSICKAG
Copy link

Tested on AppEngine 2.0.0 on TDC-E

dzekomiSICKAG
dzekomiSICKAG approved these changes Sep 23, 2024
View reviewed changes
Copy link

@dzekomiSICKAG dzekomiSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on AppEngine 2.0.0 on TDC-E

@golluroSICKAG
Copy link
Contributor Author

Thx for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzekomiSICKAG dzekomiSICKAG dzekomiSICKAG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@golluroSICKAG @dzekomiSICKAG