Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read API Key from AbuseIPDB from a file #10

Open
CyberAbwehr opened this issue Mar 11, 2021 · 3 comments · May be fixed by #11
Open

Read API Key from AbuseIPDB from a file #10

CyberAbwehr opened this issue Mar 11, 2021 · 3 comments · May be fixed by #11
Labels
enhancement New feature or request

Comments

@CyberAbwehr
Copy link

Is your feature request related to a problem? Please describe.
To automate the updates from the feeds with a script, it would be easier if your python script abuseipdb.py can read the API Key from a file.

Describe the solution you'd like
Update feeds automatically

Additional context
Add any other context or screenshots about the feature request here.

@CyberAbwehr CyberAbwehr added the enhancement New feature or request label Mar 11, 2021
@SHolzhauer
Copy link
Owner

@CyberAbwehr how would you expect the file format?

I can think of two ways to support this.

  1. A simple txt file which only contains an api key.
  2. Add support for a conf file in which the key can be specified

The file

abusekey.txt

myapikey01826

The conf file

[AbuseipDB]
apikey=myapikey012826

@CyberAbwehr
Copy link
Author

What is easier for you?
I could life with both solutions for the first step ;-)

For the future maybe it is better too but it into the conf file, because it could be that there will come more feeds with such kind of key.

@SHolzhauer
Copy link
Owner

SHolzhauer commented Mar 12, 2021

What is easier for you?

Def. the single file because that is solvable in a single place in the code whereas the conf file i'd like to implement on a general level.

For the future maybe it is better too but it into the conf file, because it could be that there will come more feeds with such kind of key.

Agreed, the conf file would also allow to store the elasticsearch connection parameters etc.

I think the conf file is the best option as this scales to new use-cases as well.

SHolzhauer added a commit that referenced this issue Mar 13, 2021
Allowing for both a file to be provided and cmd line arguments which will either
create or overwrite the configfile provided.

Working on #10
@SHolzhauer SHolzhauer linked a pull request Mar 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants