Coverage for cumulus.cli.cci #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes that warrant special attention: - Moved global functions taking an initial 'config' param from cci.py to become methods of the CliConfig class - Removed the unused 'e' arg for handle_exception_debug - Made render_recursive handle lists better. - Stop passing the return from render_recursive to click.echo, because it takes care of echoing itself. - Make check_latest_version handle its own exceptions - Removed unused --extend option for `project init` - Removed unimplemented project_list and project_cd commands - Don't echo scratch org expiration when using `org info` with the --json flag - Delegate check for whether an org can be deleted to a `can_delete` method on the org config - Remove unused --delete option for `org scratch` - Fix exception handling for `org scratch_delete - Simplify exception handling for `task run` and `flow run`
|
Looks like I need to work on a few test failures; I'll let you know when this is ready for review. |
|
Okay I think I've resolved those failures. |
cdcarter
suggested changes
Aug 9, 2018
cumulusci/cli/tests/test_cci.py
Outdated
| @@ -224,6 +225,7 @@ def test_project_init(self, click): | |||
| run_click_command(cci.project_init, obj=config) | |||
|
|
|||
| # Make sure expected files/dirs were created | |||
| print recursive_list_files() | |||
There was a problem hiding this comment.
use python3 friendly print fn plz
There was a problem hiding this comment.
Heh, this was just meant for temporary debugging anyway. Will remove.
cdcarter
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's a bit of a doozy. Some changes that warrant special attention:
project initorg infowith the --json flagcan_deletemethod on the org configorg scratchtask runandflow run