Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services Registration #225

Merged
merged 21 commits into from
Feb 8, 2017
Merged

Conversation

cdcarter
Copy link
Contributor

@cdcarter cdcarter commented Feb 2, 2017

Critical Changes

Now enforcing services and service required fields. Any services that you use in a custom task must now be defined in cumulusci.yml services.

New commands for interacting with services:

cci services list
cci services show github
cci services connect github

Changes

Issues Closed

#224 - Define services and schema

@cdcarter
Copy link
Contributor Author

cdcarter commented Feb 2, 2017

not quite ready to merge, i want servicesconfig to verify itself. but. this handles the cli side of things nicely.

@cdcarter
Copy link
Contributor Author

cdcarter commented Feb 3, 2017

  • _validate_service() on ServiceConfig
  • test cases for keychain and config
  • cherrypick out commits that are bugfixes on other things
  • documentation in the tutorial
  • docstrings
  • is the multicommand the best way to get dynamic options?
  • can I use some of jlantz's magic to access the attribute schema more easily?

@jlantz
Copy link
Contributor

jlantz commented Feb 8, 2017

This change looks great to me. I can do the doc changes pretty easily after merging. Are there other bug fixes you want to load into the branch before merge or do you just want to handle those as separate PRs?

@cdcarter
Copy link
Contributor Author

cdcarter commented Feb 8, 2017

671ecd7 and 3a303c1 are the two kind of unrelated changes that should at least be noticed, but everything is here in this PR!

@jlantz jlantz merged commit c4fa29b into SFDO-Tooling:master Feb 8, 2017
@cdcarter cdcarter deleted the feature/services branch February 8, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants