issue #258 and issue #278 - Space/Tab tokens and multiple BR/token su… #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ens and multiple BR/token support Add support for Space (SP()) and Tab (TB()) tokens; Add support for multiple tokens (including existing BR()) in delimiter
|
Awesome thanks! I agree low likelihood of regression here. #famouslastwords 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pport
Add support for Space (SP()) and Tab (TB()) tokens; Add support for
multiple tokens (including existing BR()) in delimiter
Note - This provides for backwards compat with existing "BR()" functionality. However, if an existing LookupRollupSummary contains a delimiter with the text "SP()" or "TB()" or if "BR()" exists within a delimiter that is not exactly "BR()" only, this will cause a regression. Providing a way to "escape" these tokens would require an endless exercise so due to the fact that it is extremely unlikely that these tokens already exist within a delimiter value I've decided not to provide a way to specify SP(), TB() or BR() in a delimiter that would not be translated to "space", "tab" or "carriage return." If you feel that this is something that is needed, I can update this PR to provide a backslash ("") style of escaping. Note that even with a single backslash style escaping, that too would need an escape pattern, which would need an escape pattern, etc. ;)