Issue #216 & #240 - add order by support of multiple fields, ASC/DESC and NULLS FIRST/LAST & fix to ensure recalc when order by field changes #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the preference (#223 (comment)) to leave the order by at the RollupSummaryField level rather than move it to the Context level and believe this provides as much backwards compat as possible.
The only place I could not provide 100% backwards compat is on the public member variable detailOrderBy in RollupSummaryField which changed from a Schema.DescribeField to a List<LREngine.Ordering>. It does not appear that the order by additions made in DLRS previously have made their way over to the LREngine project so this change would only effect internal DLRS usage (which I've handled in this PR) and anyone using the library source (and directly accessing this member) instead of as a package.
With all that said, I think it's worth discussing moving the order by to the context level for a couple of reasons. I'll open a new issue to explain in more detail.