Add developer API to mirror triggerHandler behavior #221
Conversation
See Issue SFDO-Community#196 and PR SFDO-Community#208 for background
When there are no oldRecords or there are no newRecords, change detection does not need to occur. Also corrected/updated comments.
| RollupService.rollup(new Map<Id, SObject>(children), new Map<Id, SObject>(newAndOldChildren), childType); | ||
|
|
||
| // Assert parents are updated | ||
| assertParents = new Map<Id, SObject>(Database.query(String.format('select id, {0} from {1}', new List<String>{ aggregateResultField, parentObjectName }))); |
There was a problem hiding this comment.
Might be worth checking Limits class before and after have not changed (within expected tolerances) for SOQL and DML usage for super paranoid testing? ;-)
|
Yeah, I covered some Limits assertions in one of the tests but I can definitely add some more. Will throw some in and update PR. Everything else look OK and inline with what you were thinking? |
|
Yes for sure, loving it actually, the tests are soooo important for this thing, its gather quite a lot of users, using it in mission critical situations, a regression would not be good! ;-) |
|
agreed and yes the library is awesome and seems to have a gained a lot of momentum. Fortunately the changes to existing code path are rather minor but still want to make sure we have all bases covered. |
|
Cool, let me know when its ready to merge. |
…ike-triggerhandler Add developer API to mirror triggerHandler behavior
With governor limits reduced based on fix for isolating master records that require update, add governor checks to trigger like dev api per @afawcette comment in PR SFDO-Community#221
See Issue #196 and PR #208 for background