Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup Summary validations not being enforced on updates after fflib upgrade #212

Closed
jondavis9898 opened this issue Jul 24, 2015 · 2 comments
Closed

Rollup Summary validations not being enforced on updates after fflib upgrade #212

jondavis9898 opened this issue Jul 24, 2015 · 2 comments
Labels
bug ready for next release

Comments

@jondavis9898
Copy link
Contributor

Prior to fflib upgrade, onValidate of RollupSummaries was invoked in onAfterInsert & onAfterUpdate. After the conversion to fflib, onValidate is only called by default during onAfterInsert which results in validations not being enforced when a rollup is updated.
@jondavis9898 jondavis9898 changed the title Rollup Summary validations not being enforced after fflib upgrade Rollup Summary validations not being enforced on updates after fflib upgrade Jul 24, 2015
jondavis9898 added a commit to jondavis9898/declarative-lookup-rollup-summaries that referenced this issue Jul 24, 2015
@jondavis9898
Issue SFDO-Community#212 - Ensure Rollup Summary validations are enfo…
d070742 
…rced on updates

Had two options here - refactor to a common validation method that is
called by both flavors of onValidate or enable
Configuration.OldOnUpdateValidateBehaviour.  Decided to go with the
former to avoid legacy based code.
@afawcett
Copy link
Collaborator

Ah good spot, kicking myself for missing that one! 👍

@afawcett
Copy link
Collaborator

Fixed in v1.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ready for next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afawcett @jondavis9898