-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod
support
#6
pod
support
#6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
LGTM in general with some minor comments.
Re formatting: LGTM, but for clean history can you format the current master and rebase your change onto it? That way we see one pure format commit and one pure functional commit.
Re testing: This was initially just me sharing my personal snippet so there isn't a good testing story for now. I'll probably set up some proper testing going forward but for this one I'll just merge with some manual testing once all comments are resolved. Thanks for highlighting that.
Also can you update README.md to reflect that pod is now supported?
d59b1b6
to
96a9487
Compare
Geez, that was a challenging git exercise for me 😅
Sure, I totally get it. 👍 It is nice first to get a feel for how it should "feel" before spending way too much time on testing infrastructure. |
afab1d6
to
d5119af
Compare
Did some manual test and everything looks good. Thanks! Before I merge, would you mind rebasing to the current head so I can fast-foward with your signed commits? |
Include some basic tests to ensure that the container + pod configurations is valid. Add test that ensures that the names for containers/pods/networks is unique to avoid cryptic error messages.
Rebased 👍 |
Hey 👋
Thanks for creating this awesome nix wrapper around quadlet! 🙏
I have added
pod
support and tried to use the same style that was used incontainer.nix
.I also added some evaluation tests to ensure that the names remain unique because I kept accidentally giving the
pod
andcontainer
the same name during tests.One thing that I am unsure about is whether or not to enforce the
.pod
suffix in the option to remain consistent with the upstream podman documentation, as they require<name>.pod
. This leads to the somewhat weird example:But to provide a better UX, I have also added an assertion that ensures that these pod options end with
.pod
and otherwise reminds the developer to add the suffix if necessary.I have also applied the official formatter, mostly because I forgot to disable automatic formatting for the repository. 😅
I haven't tried all options yet but I was wondering how the testing strategy should look like. Should I try to add nixos tests for each configuration or is it fine to start with a "manual" check and then fix things as they appear/improve upon the testing later on?
Thanks!