Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed variables and unused transaction #25

Closed
volodymyrdovhan opened this issue Oct 11, 2024 · 0 comments
Closed

Missed variables and unused transaction #25

volodymyrdovhan opened this issue Oct 11, 2024 · 0 comments

Comments

@volodymyrdovhan
Copy link

Hello,

I discovered an unused $USER variable and unnecessary transaction usage. Transactions are only necessary when processing insert/update operations, not for data reads. In any case, transactions should be closed with $transaction->allow_commit();

https://moodledev.io/docs/4.4/apis/core/dml/delegated-transactions

image

Thank you

MakinZeel pushed a commit that referenced this issue Oct 12, 2024
@MakinZeel MakinZeel mentioned this issue Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants