Reformed inventory operations, and fixed bugs #253
Conversation
| /// Creates a clone from this. | ||
| /// </summary> | ||
| /// <returns>The clone <see cref="InventoryItem"/> instance.</returns> | ||
| public InventoryItem CreateClone() |
There was a problem hiding this comment.
Did you consider implementing IClonable? Might be useful for other Classes, too. https://dotnetcoretutorials.com/2020/09/09/cloning-objects-in-c-and-net-core/ I like the idea of a CloningService which is called in the IClonable.Clone() method.
There was a problem hiding this comment.
I thought about it. I prefer the ICloneable interface with the T Clone () method.
| case 0: | ||
| ParseInventoryToInventory(packet); | ||
| //e.g when equipping a Bow (see ammo) | ||
| case 0: // InventoryToInventory |
There was a problem hiding this comment.
Can you create an enum for the type?
There was a problem hiding this comment.
Like this? enum InventoryOperation{ InventoryToInventory = 0, StorageToStorage = 1
|
I just see now, that the old methods were static. So make the new methods static too? |
I merged your pull request. I am working on inventory system. |
|
You know, my master :-) |
No description provided.