Skip to content
This repository has been archived by the owner on Oct 21, 2023. It is now read-only.

JSON conversion issues on large templates #48

Closed
scrthq opened this issue Mar 8, 2019 · 0 comments
Closed

JSON conversion issues on large templates #48

scrthq opened this issue Mar 8, 2019 · 0 comments
Assignees

Comments

@scrthq
Copy link
Member

scrthq commented Mar 8, 2019

While working with @sheldonhull in the PowerShell Slack on using VaporShell, they ran into a couple issues:

  1. Large templates would break when exporting to JSON, specifically in Windows PowerShell where Export-VaporShell pipes into a private function named Format-Json that cleans up white-space resulting from ConvertTo-Json in Windows PowerShell (PowerShell Core does not have this issue).
  2. Templates containing special characters (<,>, etc) such as imported UserData can break due to conversion of those characters to their unicode counterparts.

Working on resolving by either using Newtonsoft.Json to handle serialization to JSON or adding extra guards and cleanup using native PowerShell.

@scrthq scrthq self-assigned this Mar 8, 2019
scrthq added a commit that referenced this issue Mar 8, 2019
## 2.7.0 - 2019-03-08

* [Issue #48](#48)
  * Fixed: Export-VaporShell was having various failures due to the Format-Json private function called during JSON conversion.
* Miscellaneous
  * Brought Resource Type and Property Type functions up to current spec sheet.
  * Added: Watch and Force parameters to New-VSStack and New-VSChangeSet to watch and/or force stack creation.
  * Added: Watch parameter to Remove-VSStack and Invoke-VSChangeSetExecution to watch stack events.
  * Updated: Watch-Stack to handle multiple stack watching at once.
@scrthq scrthq closed this as completed in 81d8aee Mar 8, 2019
scrthq added a commit that referenced this issue Apr 16, 2019
## 2.7.2

* [Issue #48](#48)
  * Fixed: New-VaporMetadata now allows colons : in the LogicalId.
* Miscellaneous
  * Brought Resource Type and Property Type functions up to current spec sheet.
  * Removed automatic inclusion of AWSTemplateFormatVersion from templates created with Initialize-VaporShell.
  * Set Description parameter as Position
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant