Merge pull request #115 from Fuad-HH/gmsh_read_orient_test

Assert Counterclockwise Orientation of Read Gmsh File

meshes/square4el.msh

@@ -0,0 +1,26 @@
+$MeshFormat
+2.2 0 8
+$EndMeshFormat
+$Nodes
+5
+1 -5 -5 0
+2 -5 5 0
+3 5 5 0
+4 5 -5 0
+5 0 0 0
+$EndNodes
+$Elements
+12
+1 15 2 0 1 1
+2 15 2 0 2 2
+3 15 2 0 3 3
+4 15 2 0 4 4
+5 1 2 0 1 2 3
+6 1 2 0 2 3 4
+7 1 2 0 3 4 1
+8 1 2 0 4 1 2
+9 2 2 0 1 1 2 5
+10 2 2 0 1 4 1 5
+11 2 2 0 1 2 3 5
+12 2 2 0 1 3 4 5
+$EndElements

src/CMakeLists.txt

@@ -494,6 +494,12 @@ if(BUILD_TESTING)
   osh_add_exe(coarsen_test)
   test_func(run_coarsen_test 1 ./coarsen_test)
 
+  if(Omega_h_USE_Gmsh AND Omega_h_USE_Kokkos)
+    osh_add_exe(test_tri_vert_orientation)
+    will_fail_test_func(run_tri_orientation 1 ./test_tri_vert_orientation ${CMAKE_SOURCE_DIR}/meshes/square4el.msh)
+    set(TEST_EXES ${TEST_EXES} test_tri_vert_orientation)
+  endif()
+
   osh_add_exe(2d_conserve_test)
   test_func(serial_2d_conserve 1 ./2d_conserve_test)
   if(Omega_h_USE_MPI)
@@ -607,6 +613,7 @@ if(BUILD_TESTING)
       ${CMAKE_SOURCE_DIR}/meshes/box_3d_2p_reduce.vtk
       ${CMAKE_SOURCE_DIR}/meshes/box3d_2p_adapt.vtk)
   endif()
+
   osh_add_exe(shape_test)
   test_basefunc(run_shape_test 1 ./shape_test)
 

src/test_tri_vert_orientation.cpp

@@ -0,0 +1,69 @@
+#include <Omega_h_macros.h>
+
+#include <Omega_h_adj.hpp>
+#include <Omega_h_file.hpp>
+#include <Omega_h_mesh.hpp>
+#include <Omega_h_reduce.hpp>
+#include <cstdio>
+
+#include "Omega_h_fail.hpp"
+
+bool is_ccw_oriented(Omega_h::Mesh& mesh) {
+  OMEGA_H_CHECK_PRINTF(mesh.dim() == 2, "ERROR: Mesh is not 2D. Found Dim = %d\n", mesh.dim());
+  const auto& face2nodes = mesh.ask_down(Omega_h::FACE, Omega_h::VERT).ab2b;
+  const auto& coords = mesh.coords();
+
+  Omega_h::LO ccw;
+  Kokkos::Sum<Omega_h::LO> sum_reducer(ccw);
+  auto find_ccw_face = KOKKOS_LAMBDA(const Omega_h::LO face, Omega_h::LO& ccw) {
+    const auto faceVerts = Omega_h::gather_verts<3>(face2nodes, face);
+    const auto faceCoords = Omega_h::gather_vectors<3, 2>(coords, faceVerts);
+
+    /*
+     * It calculates the orientation based on sign of the cross product of
+     * vector AB and AC if the vertices are given as A, B, C.
+     *                   C (x3, y3)
+     *                   /\
+     *                  /  \
+     *                 /    \
+     *                /      \
+     *               ↗        \
+     *              /          \
+     *             /            \
+     *            /              \
+     *  A(x1,y1) /--------→-------\ B (x2, y2)
+     *
+     * Vector AB = (x2 - x1, y2 - y1)
+     * Vector AC = (x3 - x1, y3 - y1)
+     * Cross product = AB x AC
+     *               = - (y2 - y1) * (x3 - x1) + (x2 - x1) * (y3 - y1)
+     */
+
+    const Omega_h::LO local_ccw =
+        -(faceCoords[1][1] - faceCoords[0][1]) *
+                (faceCoords[2][0] - faceCoords[1][0]) +
+            (faceCoords[2][1] - faceCoords[1][1]) *
+                (faceCoords[1][0] - faceCoords[0][0]) >
+        0;
+    sum_reducer.join(ccw, local_ccw);
+  };
+  Kokkos::parallel_reduce("find_ccw", mesh.nfaces(), find_ccw_face, sum_reducer);
+  OMEGA_H_CHECK_PRINTF(ccw == mesh.nfaces() || ccw == 0,
+      "Expected 0 or %d but got ccw = %d\n", mesh.nfaces(), ccw);
+
+  return bool(ccw / mesh.nfaces());
+}
+
+int main(int argc, char** argv) {
+  Omega_h::Library library(&argc, &argv);
+  Omega_h::Mesh mesh(&library);
+  mesh = Omega_h::gmsh::read(argv[1], library.self());
+  bool ccw = is_ccw_oriented(mesh);
+
+  if (!ccw) {
+    std::fprintf(stderr, "ERROR: Mesh is not counter clockwise oriented\n");
+    return 1;
+  }
+
+  return 0;
+}