Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New signal slots for Qt 6 #2381

Merged
merged 59 commits into from
Apr 21, 2022
Merged

New signal slots for Qt 6 #2381

merged 59 commits into from
Apr 21, 2022

Conversation

dcwhite
Copy link
Member

@dcwhite dcwhite commented Apr 13, 2022

Convert almost all of the old-style SIGNAL/SLOT Qt macros to the new function pointer syntax. Nearly closes #1993.

Also includes some new GUI features.

Requesting lots of reviewers to test for GUI bugs (non-working buttons or other widgets, mostly).

I'll post a link to the binaries here once they're done.

@dcwhite dcwhite self-assigned this Apr 13, 2022
@dcwhite
Copy link
Member Author

dcwhite commented Apr 13, 2022

Looks like I need to update some calls for older Qt on older Linux. Fix coming soon

@jessdtate jessdtate self-requested a review April 20, 2022 17:59
@jessdtate
Copy link
Contributor

@dcwhite make sure that you review changes to splitfieldbyconnectedregion

@jab0707
Copy link

jab0707 commented Apr 21, 2022

are there binaries yet for testing?

@dcwhite
Copy link
Member Author

dcwhite commented Apr 21, 2022

@dcwhite
Copy link
Member Author

dcwhite commented Apr 21, 2022

this branch does not have the packaging fix in it, so that's the non-python package

@jab0707
Copy link

jab0707 commented Apr 21, 2022

does there also happen to be a windows version? If not I can just test mac.

@dcwhite
Copy link
Member Author

dcwhite commented Apr 21, 2022

@dcwhite dcwhite merged commit 21f4c2b into master Apr 21, 2022
@dcwhite dcwhite deleted the new-signal-slots branch April 21, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt 5: convert connect calls to new generic syntax
3 participants