Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSPRay: ColorMap Rescaling Fix #2361

Merged
merged 3 commits into from
Jan 22, 2022
Merged

OSPRay: ColorMap Rescaling Fix #2361

merged 3 commits into from
Jan 22, 2022

Conversation

tarkpate
Copy link
Contributor

@tarkpate tarkpate commented Jan 1, 2022

Issue #2341

Turned out that the value range being passed to OSPRay was the range of the field, not the range defined by the color map rescaling.

  • Fixed color map rescaling
  • Added min and max variables to the color map helper class
  • Changed the naming convention of the color map helper class to match the rest of SCIRun
  • typo fix
  • added test network

@dcwhite dcwhite requested review from dcwhite and jessdtate January 5, 2022 19:53
@dcwhite dcwhite added this to the 5.0-beta.ϴ [Internal] milestone Jan 5, 2022
@dcwhite dcwhite self-assigned this Jan 5, 2022
@dcwhite dcwhite added the Ospray label Jan 5, 2022
@dcwhite dcwhite enabled auto-merge January 21, 2022 21:32
@dcwhite dcwhite merged commit f02ad9d into SCIInstitute:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessdtate jessdtate jessdtate approved these changes

@dcwhite dcwhite dcwhite approved these changes

Assignees

@dcwhite dcwhite

Labels
Ospray
Projects
None yet
Milestone
5.0-beta.ZZZ [Conference]
Development

Successfully merging this pull request may close these issues.
3 participants
@tarkpate @dcwhite @jessdtate