Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Glyphs Normals #2320

Merged
merged 17 commits into from
Jan 21, 2022
Merged

Show Glyphs Normals #2320

merged 17 commits into from
Jan 21, 2022

Conversation

tarkpate
Copy link
Contributor

This is a debugging tool for glyph normals. To show normals, I had to refactor the glyph constructor class. I extracted the private data members to a struct such that points, lines, and triangles had their data isolated.

I added 2 new state variables to ShowFieldGlyphs:
ShowNormals(bool)
ShowNormalsScale(double)
Since this is a debugging tool, I didn't make a button for it. You have to set through the python api.

@dcwhite dcwhite requested review from dcwhite and jessdtate August 13, 2021 18:02
@dcwhite dcwhite self-assigned this Aug 13, 2021
@dcwhite dcwhite added this to the 5.0-beta.ϴ [Internal] milestone Aug 13, 2021
Copy link
Member

@dcwhite dcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first wave of line-level review

src/Graphics/Glyphs/GlyphConstructor.cc Outdated Show resolved Hide resolved
src/Graphics/Glyphs/GlyphConstructor.cc Outdated Show resolved Hide resolved
src/Graphics/Glyphs/GlyphConstructor.cc Outdated Show resolved Hide resolved
src/Graphics/Glyphs/GlyphConstructor.cc Outdated Show resolved Hide resolved
src/Graphics/Glyphs/GlyphConstructor.h Outdated Show resolved Hide resolved
@dcwhite dcwhite merged commit 8ca9de2 into SCIInstitute:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants