Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added windows-tests on github actions #244

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

pabloitu
Copy link
Collaborator

@pabloitu pabloitu commented Nov 15, 2023

Addresses #237

Tested the GA on my fork and works ok!

ga: added only windows 3.10
ga: updated github actions to test windows. fix jma tests
ga: reverted to run GA on maaster(main) branch & fork

pyCSEP Pull Request Checklist

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

ga: updated github actions to test windows. fix jma tests
ga: reverted to run GA on maaster(main) branch & fork
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e2badb) 54.95% compared to head (b0f9189) 54.95%.

❗ Current head b0f9189 differs from pull request most recent head 04d6006. Consider uploading reports for the commit 04d6006 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files          23       23           
  Lines        3963     3963           
  Branches      578      578           
=======================================
  Hits         2178     2178           
  Misses       1648     1648           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fabiolsilva fabiolsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed test_JmaCsvCatalog to use date time_to_utc_epoch function, added Windows to testing matrix.

@fabiolsilva fabiolsilva merged commit 083c5ca into SCECcode:main Jan 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants