Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2887 Parametrized pool Medium/High Priority: #2921

Merged
merged 5 commits into from
Jun 28, 2024
Merged

#2887 Parametrized pool Medium/High Priority: #2921

merged 5 commits into from
Jun 28, 2024

Conversation

Limraj
Copy link
Collaborator

@Limraj Limraj commented Jun 15, 2024

  • added parametrized pool threads for: high, medium, low priority in env.properties;
  • created classes: ThreadPoolExecutorUtils, ThreadPoolExecutorConfig, BlockingQueuesUtils,TimeUnitUtils;
  • added tests: BlockingQueuesUtilsTest, ThreadPoolExecutorConfigSystemSettingsUtilsTest, SystemSettingsTestsSuite;
  • corrected translation for key header.title;

@Limraj
#2887 Parametrized pool Medium/High Priority:
2d28542 
- added parametrized pool threads for: high, medium, low priority in env.properties;
- created classes: ThreadPoolExecutorUtils, ThreadPoolExecutorConfig, BlockingQueuesUtils,TimeUnitUtils;
- added tests: BlockingQueuesUtilsTest, ThreadPoolExecutorConfigSystemSettingsUtilsTest, SystemSettingsTestsSuite;
- corrected translation for key header.title;
@Limraj Limraj added this to the 2.7.8 milestone Jun 15, 2024
@Limraj Limraj requested a review from SoftQ as a code owner June 15, 2024 21:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 15, 2024 •
edited
Loading

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✅ ±0   4s ⏱️ ±0s
 70 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4542b48. ± Comparison against base commit 6c58738.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 15, 2024 •
edited
Loading

Java JUnit Test Results

2 089 tests  +48   2 089 ✅ +48   26s ⏱️ ±0s
  107 suites + 2       0 💤 ± 0 
  107 files   + 2       0 ❌ ± 0 

Results for commit 4542b48. ± Comparison against base commit 6c58738.

♻️ This comment has been updated with latest results.

@Limraj
#2887 Parametrized pool Medium/High Priority:
89d600a 
- created class: CreateObjectUtils;
- corrected CreateObjectUtils.parseObjects for empty strings;
@Limraj Limraj requested a review from Patrykb0802 June 15, 2024 22:43
Limraj added 3 commits June 25, 2024 08:59
@Limraj
#2887 Parametrized pool Medium/High Priority:
0f6f53b 
- removed throw exceptions;
@Limraj
#2887 Parametrized pool Medium/High Priority:
ea753a6 
- use WorkItemPriority type;
- added configuration BatchWriteBehind work item: MAX_ROWS, MAX_INSTANCES, SPAWN_THRESHOLD;
@Limraj
#2887 Parametrized pool Medium/High Priority:
4542b48 
- reduce medium-priority.core-pool-size to 6;
Patrykb0802
Patrykb0802 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Patrykb0802 Patrykb0802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍

@Limraj Limraj merged commit 4f83be1 into release/2.7.8 Jun 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrykb0802 Patrykb0802 Patrykb0802 approved these changes

@SoftQ SoftQ Awaiting requested review from SoftQ SoftQ is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Limraj @Patrykb0802