Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed event handlers new xid not displaying after saving edit form #2824

Closed
Patrykb0802 opened this issue Feb 14, 2024 · 0 comments
Closed

Fixed event handlers new xid not displaying after saving edit form #2824

Patrykb0802 opened this issue Feb 14, 2024 · 0 comments
Assignees
@Patrykb0802
Labels
bug to check
Milestone
2.8.0

Comments

@Patrykb0802
Copy link
Contributor

When editing already created event handler after deleting xid and saving, completely new xid is generated but not shown until you re-choose that event handler

To Reproduce

  1. Go to Event Handlers
  2. Pick any event handler and save it
  3. Select just saved event handler
  4. Delete xid and save -> "Event Handler have been saved" -> No visible xid in editing form -> error

Expected behavior
It should behave same way as when creating event handler, when you click save, new xid should appear automatically

Desktop:

  • OS: Linux Mint
  • Browser Chrome
  • Version 2.7.6.1

Additional context
Look for edit form refresh when creating event handler, applying same logic when saving edited event handler should get rid of this problem.
@Limraj Limraj added the to check label Jul 7, 2024
@Limraj Limraj added this to the 2.8.0 milestone Jul 7, 2024
@Patrykb0802 Patrykb0802 self-assigned this Jul 8, 2024
@Limraj Limraj modified the milestones: 2.8.0, 2.9.0 Jul 14, 2024
Patrykb0802 added a commit that referenced this issue Jul 18, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
f204e8c
Patrykb0802 added a commit that referenced this issue Jul 18, 2024
@Patrykb0802
Revert "#2824 Fixed event handlers new xid not displaying after savin…
2d7ea69 
…g edit form"

This reverts commit f204e8c.
Patrykb0802 added a commit that referenced this issue Jul 18, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
c4b3c6a
Patrykb0802 added a commit that referenced this issue Jul 22, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
302c17e 
- Added isNotEmpty() to common.js
- Moved validateValue() to common.js
- Added restoring previous XID value for Event Handlers when XID field is left empty when saving Event Handler
Patrykb0802 added a commit that referenced this issue Jul 22, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
25ccc99
Patrykb0802 added a commit that referenced this issue Jul 24, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
e9247d2
Patrykb0802 added a commit that referenced this issue Jul 24, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
2551734 
- Code formatting adjustments
Patrykb0802 added a commit that referenced this issue Jul 24, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
8052cb6
Patrykb0802 added a commit that referenced this issue Jul 24, 2024
@Patrykb0802
#2824 Fixed event handlers new xid not displaying after saving edit form
dbd759d 
- Adjusted code formatting
Limraj added a commit that referenced this issue Jul 24, 2024
@Limraj
Merge pull request #2959 from SCADA-LTS/fix/#2824_Fixed_event_handler…
7b25463 
…s_new_xid_not_displaying_after_saving_edit_form2

#2824 Fixed event handlers new xid not displaying after saving edit form
@Limraj Limraj closed this as completed Jul 24, 2024
@Limraj Limraj modified the milestones: 2.9.0, 2.8.0 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Patrykb0802 Patrykb0802

Labels
bug to check
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
2 participants
@Limraj @Patrykb0802