Workaround node.js bug with readline #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 92.98% 92.99% +<.01%
==========================================
Files 26 26
Lines 1069 1070 +1
Branches 23 23
==========================================
+ Hits 994 995 +1
Misses 75 75
Continue to review full report at Codecov.
|
|
Yeah, let's get someone to confirm if this works on their windows environment before moving ahead. I do not have any windows machine handy personally. |
|
Can confirm this fixed the issue on: |
|
Alright, I'll prepare a release tomorrow and monitor issues closely if something comes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SBoudrias, please publish a reverted 7.0.3.
And this PR as an pre-release or beta if possible.