Fix(inquirer): Rework type interface #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
=======================================
Coverage ? 97.88%
=======================================
Files ? 37
Lines ? 2365
Branches ? 626
=======================================
Hits ? 2315
Misses ? 44
Partials ? 6 ☔ View full report in Codecov by Sentry. |
SBoudrias
reviewed
Aug 31, 2024
This reverts commit 621aa2d988592ef21c92fd6f69f4e61353ac81b8.
SBoudrias
reviewed
Sep 2, 2024
This reverts commit c9f0747.
|
Alright, I'm pretty happy with the state this is in! I'll merge. Thanks a ton for the work you put in there! I think this implementation better balance the tradeoffs around types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.