-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added error callback for when we fail in onEnd #1265
Conversation
Hi @mastrzyz, thanks for sending a PR. Could you help fixing the CI issues? And instead of an examples, adding a unit test would be more resilient - so it'd be awesome if you have time to add that in! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
+ Coverage 72.29% 76.94% +4.64%
==========================================
Files 42 42
Lines 4083 4138 +55
Branches 665 735 +70
==========================================
+ Hits 2952 3184 +232
+ Misses 475 228 -247
- Partials 656 726 +70
☔ View full report in Codecov by Sentry. |
Hey @SBoudrias , fixed CI and added a UT!, let me know if this is fine or you would like one for each prompt. |
No description provided.