Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error callback for when we fail in onEnd #1265

Closed
wants to merge 10 commits into from

Conversation

mastrzyz
Copy link
Contributor

No description provided.

@SBoudrias
Copy link
Owner

Hi @mastrzyz, thanks for sending a PR.

Could you help fixing the CI issues? And instead of an examples, adding a unit test would be more resilient - so it'd be awesome if you have time to add that in!

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 78.26% and project coverage change: +4.64% 🎉

Comparison is base (c4d0626) 72.29% compared to head (729a554) 76.94%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   72.29%   76.94%   +4.64%     
==========================================
  Files          42       42              
  Lines        4083     4138      +55     
  Branches      665      735      +70     
==========================================
+ Hits         2952     3184     +232     
+ Misses        475      228     -247     
- Partials      656      726      +70     
Files Changed Coverage Δ
packages/inquirer/lib/prompts/confirm.js 80.76% <76.92%> (-1.05%) ⬇️
packages/inquirer/lib/prompts/input.js 83.92% <80.00%> (-2.06%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mastrzyz
Copy link
Contributor Author

mastrzyz commented Aug 4, 2023

Hey @SBoudrias , fixed CI and added a UT!, let me know if this is fine or you would like one for each prompt.

@SBoudrias SBoudrias closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants