Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.5.1 deps and Node.js 6.x #837

Closed
XhmikosR opened this issue Aug 12, 2019 · 7 comments
Closed

v6.5.1 deps and Node.js 6.x #837

XhmikosR opened this issue Aug 12, 2019 · 7 comments

Comments

@XhmikosR
Copy link

XhmikosR commented Aug 12, 2019

@SBoudrias: it seems you did some major version updates in dependencies and those drop Node.js 6.x support, like:

And for devDependencies [email protected]

But the package was published as a patch version. This violates semver and will break things. I suggest that you downgrade to the previous versions that supported Node.js 6.x, release a 6.5.2 version and then, if you want to bump those deps, make it major version bump.

@XhmikosR XhmikosR changed the title v6.5.1 breaks Node.js 6.x v6.5.1 deps and Node.js 6.x Aug 12, 2019
@XhmikosR
Copy link
Author

Friendly bump @SBoudrias. This is quite a serious regression that affects the ecosystem.

BTW don't get me wrong, I'm all for dropping Node.js 6.x support, but should be done properly with a major version bump after a patch has been released to restore 6.x support.

rwjblue added a commit to ember-cli/ember-resolver that referenced this issue Aug 14, 2019
@IvanGoncharov
Copy link

@SBoudrias I fully agree with @XhmikosR comment:

BTW don't get me wrong, I'm all for dropping Node.js 6.x support, but should be done properly with a major version bump after a patch has been released to restore 6.x support.

I maintain graphql-js and we plan to drop Node.js 6.x but we plan to make major release next month so this situation creates a lot of inconveniences.
Can you please release 6.5.2 at supports Node v6?

@rwjblue
Copy link

rwjblue commented Aug 22, 2019

FWIW, this is also causing a bit of issues in the Ember ecosystem. Many packages have already updated to drop Node 6 support (with major version bumps) but some are waiting for specific circumstances to do a major version bump (e.g. a new feature on the way).

@SBoudrias
Copy link
Owner

Thanks for the feedback everyone. I'll release a rollback on the 6.x series and bump latest to 7.x

Just give me a few days to have time to handle this.

@SBoudrias
Copy link
Owner

Actually I took some time right now to do this. Should be fine now:

New versions:

  • v7.x is latest master, it drops supports for Node 6
  • v6.5.2 who's v6.5.0 republished to replace v6.5.1

@XhmikosR
Copy link
Author

Thanks!

@rwjblue
Copy link

rwjblue commented Aug 23, 2019

Thank you very much @SBoudrias! Sorry for the extra work, but it was very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants