Chore(all): Enforce usage of replaceAll instead of replace

SBoudrias · Apr 25, 2024 · fe0ebdb · fe0ebdb
1 parent 018d4d5
commit fe0ebdb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -51,7 +51,8 @@
     "prettier/prettier": "error",
     "unicorn/no-abusive-eslint-disable": "error",
     "unicorn/prefer-module": "error",
-    "unicorn/prefer-node-protocol": "error"
+    "unicorn/prefer-node-protocol": "error",
+    "unicorn/prefer-string-replace-all": "error"
   },
   "overrides": [
     {

diff --git a/packages/inquirer/lib/prompts/checkbox.js b/packages/inquirer/lib/prompts/checkbox.js
@@ -258,7 +258,7 @@ function renderChoices(choices, pointer) {
     output += '\n';
   });
 
-  return output.replace(/\n$/, '');
+  return output.replaceAll(/\n$/g, '');
 }
 
 /**

diff --git a/packages/inquirer/lib/prompts/list.js b/packages/inquirer/lib/prompts/list.js
@@ -199,5 +199,5 @@ function listRender(choices, pointer) {
     output += line + ' \n';
   });
 
-  return output.replace(/\n$/, '');
+  return output.replaceAll(/\n$/g, '');
 }
diff --git a/tools/fix-ext.mjs b/tools/fix-ext.mjs
@@ -10,7 +10,7 @@ mjsFiles.forEach(async (pathname) => {
   const fileContent = await fs.readFile(pathname, 'utf-8');
   await fs.writeFile(
     pathname,
-    fileContent.replace(/require\(['"]([^'"]*)\.mjs['"]\)/g, "require('$1.js')"),
+    fileContent.replaceAll(/require\(['"]([^'"]*)\.mjs['"]\)/g, "require('$1.js')"),
   );
 
   // 2. Rename files
@@ -32,7 +32,7 @@ dmtsFiles.forEach(async (pathname) => {
   const fileContent = await fs.readFile(pathname, 'utf-8');
   await fs.writeFile(
     pathname,
-    fileContent.replace(/from '([^']*)\.mjs'/g, "from '$1.js'"),
+    fileContent.replaceAll(/from '([^']*)\.mjs'/g, "from '$1.js'"),
   );
 
   // 2. Rename files
-Original file line number
+Diff line change
@@ Expand Up / @@ -258,7 +258,7 @@ function renderChoices(choices, pointer) { @@
         output += '\n';
       });
-      return output.replace(/\n$/, '');
+      return output.replaceAll(/\n$/g, '');
     }
     /**
@@ Expand Down @@