Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-dynamic-page: slider handler visible through header content #9560

Closed
1 task done
MarcusNotheis opened this issue Jul 25, 2024 · 1 comment · Fixed by #9568
Closed
1 task done

ui5-dynamic-page: slider handler visible through header content #9560

MarcusNotheis opened this issue Jul 25, 2024 · 1 comment · Fixed by #9568
Assignees
@plamenivanov91
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@MarcusNotheis
Copy link
Collaborator

MarcusNotheis commented Jul 25, 2024 •
edited
Loading

Bug Description

When rendering a ui5-slider in the ui5-dynamic-page, the slider handle is visible through the header content when the page is scrolled down.
This was originally reported in the custom React DynamicPage component, but is occurring in the new ui5-dynamic-page as well: SAP/ui5-webcomponents-react#6107

Affected Component

ui5-dynamic-page

Expected Behaviour

Slider Handle should not be visible

Isolated Example

UI5 Playground Link

Steps to Reproduce

  1. Open the linked playground
  2. Scroll down
  3. See the slider handle through the header content

Log Output, Stack Trace or Screenshots

image

Priority

Medium

UI5 Web Components Version

2.0.1

Browser

Chrome, Edge, Firefox, Safari

Operating System

MacOS

Additional Context

Bugfix from Web Components React (v1): SAP/ui5-webcomponents-react#6116

Organization

UI5 Web Components for React

Declaration

  • I’m not disclosing any internal or sensitive information.
@MarcusNotheis MarcusNotheis added the bug This issue is a bug in the code label Jul 25, 2024
@kgogov kgogov self-assigned this Jul 26, 2024
@kgogov
Copy link
Member

kgogov commented Jul 26, 2024

Hello @MarcusNotheis,

Thank you for sharing this finding.
I am forwarding this ticket to the responsible team, who will look into it and assist.

@SAP/ui5-webcomponents-topic-p, could you please look into this?

Regards,
Konstantin Gogov
UI5 Web Components GitHub Dispatcher

@kgogov kgogov removed their assignment Jul 26, 2024
@plamenivanov91 plamenivanov91 self-assigned this Jul 26, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Jul 26, 2024
@plamenivanov91
fix(ui5-dynamic-page): fixed wrong overlapping in header area
26b8acd 
There was a problem where the handle of the Slider components was
overlapping over the Dynamic Page header area. This was due to equal
z-index of both the handle and the Dynamic Page header wrapper.

This change increases the z-index of the header wrapper making sure that
the handle of the slider is always rendered under it and not overlapping.

Fixes: SAP#9560
@plamenivanov91 plamenivanov91 mentioned this issue Jul 26, 2024
Merged
@plamenivanov91 plamenivanov91 moved this from Issues to In Progress in Maintenance - Topic P Jul 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Aug 1, 2024
@MarcusNotheis MarcusNotheis mentioned this issue Sep 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamenivanov91 plamenivanov91

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-dynamic-page): fixed wrong overlapping in header area plamenivanov91/ui5-webcomponents
3 participants
@MarcusNotheis @plamenivanov91 @kgogov