chore: replace XMLHttpRequest with global fetch in ace third party #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdichev
approved these changes
Mar 26, 2024
|
🎉 This PR is included in version 1.6.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Manifest V3 migration guide prescribes to "Replace calls from your background script to XMLHttpRequest() with calls to global fetch()"
Ref: https://developer.chrome.com/docs/extensions/develop/migrate/to-service-workers#replace-xmlhttprequest
The only place in the codebase that contains call to XMLHttpRequest is the third party ace editor
Ref: https://github.com/ajaxorg/ace/blob/master/src/lib/net.js#L12
Modified the ace sources to overwrite the function that calls XMLHttpRequest with a function that uses fetch to make the same request.