Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Fix logger-related tests #871

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Jan 17, 2023

SAP/ui5-logger#363 made logger modules more
restrictive.

  • XMLCompositeAnalyzer must provide a module name to create a logger
    instance
  • generateLibraryPreload integration tests need to be executed in
    sequence to prevent issues with the stateful BuildLogger

Depends on SAP/ui5-project#537

JIRA: CPOUI5FOUNDATION-603

SAP/ui5-logger#363 made logger modules more
restrictive.

* XMLCompositeAnalyzer must provide a module name to create a logger
  instance
* generateLibraryPreload integration tests need to be executed in
  sequence to prevent issues with the stateful BuildLogger
@RandomByte RandomByte requested a review from a team January 17, 2023 20:11
@coveralls
Copy link

coveralls commented Jan 17, 2023

Coverage Status

Coverage: 94.608%. Remained the same when pulling 40d757a on fix-logger-related-tests into 125003d on main.

@RandomByte RandomByte merged commit 53b5761 into main Jan 19, 2023
@RandomByte RandomByte deleted the fix-logger-related-tests branch January 19, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants