Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tenantName): remove invalid characters from tenant name #88

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Phil91
Copy link
Collaborator

@Phil91 Phil91 commented Aug 20, 2024

Description

  • check for invalid characters in company name when creating the tenant, if existing remove those.
  • use only the bpn for the the subdomain when creating the subAccount

Why

The sap wallet only accepts letters, digits and hyphens (not at the start or end)

Issue

Refs: #86 #87

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 force-pushed the bugfix/86-subdomain branch from f521d68 to da493c6 Compare August 20, 2024 14:04
@Phil91 Phil91 force-pushed the bugfix/86-subdomain branch from da493c6 to 327974f Compare August 21, 2024 05:39
@Phil91 Phil91 added the priority label Sep 9, 2024
@Phil91 Phil91 requested a review from evegufy September 9, 2024 07:49
@Phil91 Phil91 merged commit d44ef09 into main Sep 12, 2024
7 checks passed
@Phil91 Phil91 deleted the bugfix/86-subdomain branch September 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants