Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-9048) - Fix popover and dropdown appearance when a High Contrast Theme is applied. #19840

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

petarmarkov9449
Copy link
Contributor

@petarmarkov9449 petarmarkov9449 commented Jan 8, 2025

Closes: CXSPA-9048

Fix popover and dropdown appearance when a High Contrast Theme is applied.

@petarmarkov9449 petarmarkov9449 requested a review from a team as a code owner January 8, 2025 11:25
@github-actions github-actions bot marked this pull request as draft January 8, 2025 11:25
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 8, 2025 11:31
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft January 8, 2025 11:35
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 8, 2025 12:00
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft January 8, 2025 12:15
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 8, 2025 12:15
@github-actions github-actions bot marked this pull request as draft January 8, 2025 12:16
Copy link

cypress bot commented Jan 8, 2025

spartacus    Run #46760

Run Properties:  status check passed Passed #46760  •  git commit d60144cbc6 ℹ️: Merge f4992fade7b1dcb2a0d696123639af7502bf32f5 into 40c9daa2f6101dbb80d7bbf506ee...
Project spartacus
Branch Review feature/CXSPA-9048
Run status status check passed Passed #46760
Run duration 04m 06s
Commit git commit d60144cbc6 ℹ️: Merge f4992fade7b1dcb2a0d696123639af7502bf32f5 into 40c9daa2f6101dbb80d7bbf506ee...
Committer petarmarkov9449
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 8, 2025 12:16
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft January 8, 2025 12:33
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 8, 2025 13:09
@github-actions github-actions bot marked this pull request as draft January 20, 2025 09:48
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 20, 2025 11:03
Copy link
Contributor

@Pio-Bar Pio-Bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine although I think this problem may have been resolved already, can you double check?

@petarmarkov9449
Copy link
Contributor Author

For dropdown menu, it is not resolved yet @Pio-Bar

@github-actions github-actions bot marked this pull request as draft January 20, 2025 16:10
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 20, 2025 16:16
@petarmarkov9449 petarmarkov9449 merged commit 8283000 into develop Jan 20, 2025
28 checks passed
@petarmarkov9449 petarmarkov9449 deleted the feature/CXSPA-9048 branch January 20, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants