bootstrap #19810
Draft
bootstrap #19810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "@angular-eslint/eslint-plugin" bumped to `17.3.0`, - "@angular-eslint/eslint-plugin-template" bumped to `17.3.0`, - "@angular-eslint/template-parser" bumped to `17.3.0`, - "@nx/angular" bumped to `20.1.3` - "@nx/devkit" bumped to `20.1.3` - "@nx/eslint-plugin" bumped to `20.1.3` - "@nx/jest" bumped from `17.3.2` to `20.0.0` - "@nx/workspace" bumped to `20.1.3` - "@types/jest" bumped to `29.5.14` - "jest" bumped to `29.7.0` - "jest-preset-angular" bumped to `14.1.1` - "nx" bumped to `20.1.3`, - `"useInferencePlugins": false` added to `nx.json` for more, see: https://nx.dev/concepts/inferred-tasks#existing-nx-workspaces - `"useLegacyCache": true` added to `nx.json` for more, see: https://nx.dev/nx-api/devkit/documents/Workspace#uselegacycache - `/.nx/workspace-data` added to `.gitignore` and `.prettierignore`
- "@angular/ssr" bumped to "18.2.9" - "@angular-devkit/build-angular" bumped to "18.2.9" - "@angular-devkit/core" bumped to "18.2.9" - "@angular-devkit/schematics" bumped to "18.2.9" - "@angular/cli": "18.2.9" bumped to "18.2.9"
- "@angular/animations" bumped to "18.2.9", - "@angular/common" bumped to "18.2.9", - "@angular/compiler" bumped to "18.2.9", - "@angular/core" bumped to "18.2.9", - "@angular/forms" bumped to "18.2.9", - "@angular/platform-browser" bumped to "18.2.9", - "@angular/platform-browser-dynamic" bumped to "18.2.9", - "@angular/platform-server" bumped to "18.2.9", - "@angular/compiler-cli" bumped to "18.2.9", - "@angular/language-service" bumped to "18.2.9", - "@angular/pwa" bumped to "18.2.9", - "@schematics/angular" bumped to "18.2.9", - replaced deprecated HTTP related modules with provider functions
- "@ngrx/effects" bumped to "18.1.1" - "@ngrx/router-store" bumped to "18.1.1" - "@ngrx/store" bumped to "18.1.1" - "@ngrx/store-devtools" bumped to "18.1.0" - "@ngrx/operators" introduced with version "^18.0.0" - `TypedAction` removed in favour of `Action` in `pickup-location.action.ts`
- "@ng-select/ng-select" bumped to "13.9.1" - "@ngrx/effects" bumped to "18.1.1" - "@ngrx/router-store" bumped to "18.1.1" - "ngx-infinite-scroll" bumped to "18.0.0" - "zone.js" updated to "0.14.10" - "@angular-builders/custom-webpack" bumped to "18.0.0" - "@angular-eslint" dependencies updated to "18.4.2" - "@typescript-eslint" dependencies updated to "7.2.0" - "eslint" bumped to "8.57.0"
- added new `@stylistic/eslint-plugin-ts` due to moving some there som config from `@typescript-eslint/eslint-plugin`: - `quotes` - `member-delimiter-style` - `semi` - type-annotation-spacing` for more, see e.g.: https://typescript-eslint.io/rules/member-delimiter-style/ - removed redundant rules from `legacy-ng-cli-compat` files
- replaced `Observable<boolean | UrlTree> with combined `Observable<GuardResult>` from @angular/router for more, see: angular/angular#45023 - add `node` to "types" in all `tsconfig.schematics.json` to support node API - remove redundant `dist` and `assets` property from nested ng-package.json in CDP, OPF and OMF for more, see: https://github.com/ng-packagr/ng-packagr/pull/2754/files
- "@typescript-eslint/eslint-plugin" bumped to "8.9.0"
- "@typescript-eslint/parser" bumped to "8.9.0"
- "@typescript-eslint/utils" bumped to "8.9.0"
- add support for `RedirectCommand` type in guard tests - adjust `ng-select-a11y.directive.ts` to look for `input[aria-controls="order-return-table"]` instead of `div[aria-controls="order-return-table"]` due to changes in `ng-select` library for more, see: ng-select/ng-select#2428 - adjust `order-return-requrest-list.component.spec.ts` to look for `input[aria-controls="order-return-table"]` instead of `div[aria-controls="order-return-table"]` due to changes in `ng-select` for more, see: ng-select/ng-select#2428 - remove `recommended` property from eslint rules - add `fix-jsdom-environment.ts` containing fix for missing support of structuredClone in `jest-environment-jsdom` for more, see: jsdom/jsdom#3363 (comment) - `convertAnnotatedSourceToFailureCase` is now imported from `@angular-eslint/test-utils`(new dependency) instead from `@angular-eslint/utils` - include TS files in `tsconfig.spec.json`
- update snapshots - adjust type in 'file-utils_spec.ts' file
- update snapshots - add missing `test-jest` command to project.json in the following libs: 'estimated-delivery-date', 'pdf-invoices', 'requested-delivery-date' and 'cpq-quote'
- fixed issues caught after bumping minor version of "stylelint" packages (when upgrading package-lock.json) - added "integration-libs" to the linter scope
- adjusted 'form-errors.component.ts' to new 'AbstractControl' - it uses signals and getters under the hood so the differ won't work for the comparison - marked `MessageService` as optional in `FormComponent` - the issue with this service was shown after updating t v18 and will be fixed in a separate ticket - removed `MessageService` from `FormModule` providers
- use RuleTester from '@angular-eslint/test-utils' package - remove casting to TSESLint.InvalidTestCase from test cases
- adjust schema.json in feature-libs/cart - adjust schema.json in feature-libs/checkout - adjust schema.json in feature-libs/organization - adjust schema.json in feature-libs/product - adjust schema.json in feature-libs/product-multi-dimensional - adjust schema.json in feature-libs/tracking - adjust schema.json in feature-libs/user - adjust schema.json in integration-libs/opf - adjust schema.json in integration-libs/s4om - adjust schema.json in project/schematics
- replace with RouterModule.forRoot([]) where needed - remove redundant usage of RouterTestingModule
…/CXSPA-9094-remove-bootsrap # Conflicts: # extra-webpack.config.js # package-lock.json
- Commented out unused Bootstrap imports in storefrontstyles' files: `app.scss`, `alert.scss`, `buttons.scss`, `card.scss`, `dropdown.scss`, `forms.scss`, `modal.scss`, and `tooltip.scss`
…asses @extend'ing Bootstrap modal classes
…rting Bootstrap, instead of importing it inside '@spartacus/styles'
spartacus-serviceuser
had a problem deploying
to
dev
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.