Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update open-sans, jsonc-parser, tslib deps #19798

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

rmch91
Copy link
Contributor

@rmch91 rmch91 commented Dec 20, 2024

@rmch91 rmch91 requested review from a team as code owners December 20, 2024 13:41
@github-actions github-actions bot marked this pull request as draft December 20, 2024 13:41
@rmch91 rmch91 marked this pull request as ready for review December 20, 2024 13:43
Copy link

cypress bot commented Dec 20, 2024

spartacus    Run #46554

Run Properties:  status check passed Passed #46554  •  git commit 6ffcabc8d5 ℹ️: Merge fc31cb18bce9ff1c76dfffd5dacd3a28021f5e68 into ed738dffc1e0e156d1c791b544ce...
Project spartacus
Branch Review feat/CXSPA-9134
Run status status check passed Passed #46554
Run duration 11m 48s
Commit git commit 6ffcabc8d5 ℹ️: Merge fc31cb18bce9ff1c76dfffd5dacd3a28021f5e68 into ed738dffc1e0e156d1c791b544ce...
Committer Roman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft January 2, 2025 20:09
Copy link
Contributor

@kimhw0630 kimhw0630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done build test and looks good to me

@kimhw0630 kimhw0630 marked this pull request as ready for review January 2, 2025 20:46
@github-actions github-actions bot marked this pull request as draft January 7, 2025 11:32
@rmch91 rmch91 marked this pull request as ready for review January 7, 2025 11:32
@github-actions github-actions bot marked this pull request as draft January 7, 2025 13:22
@rmch91 rmch91 marked this pull request as ready for review January 7, 2025 13:22
@rmch91 rmch91 merged commit 7cab5e6 into develop Jan 7, 2025
28 checks passed
@rmch91 rmch91 deleted the feat/CXSPA-9134 branch January 7, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants