fix: (CXSPA-8997 & 8988) - Resolve Aria Issues in NavigationUIComponent #19782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-8997
|
| Run status |
|
| Run duration | 04m 12s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
sdrozdsap
reviewed
Dec 19, 2024
| [attr.aria-haspopup]="true" | ||
| [attr.aria-expanded]="false" | ||
| [attr.aria-controls]="node.title" | ||
| [attr.aria-describedby]="getAriaDescribedbyOfButton(node)" |
There was a problem hiding this comment.
You've added it for negated cxFeature therefore if a11yButtonAriaFixes is enabled this won't be used.
However when I change it on my local it solves the previous errors, but there is one more new one:
sdrozdsap
reviewed
Dec 19, 2024
| * Returns the ID for the `aria-describedby` attribute of a button. | ||
| */ | ||
| getAriaDescribedbyOfButton(node: NavigationNode): string | null { | ||
| return node.title === 'My Account' ? 'greeting' : null; |
There was a problem hiding this comment.
Hm, it doesn't seem right to use the title as an identifier of the node. If this aria described by is used only for my account navigation, maybe we can pass down some input from my-account-v2-navigation.component.ts where <cx-navigation-ui> is used. Thats just from the top of my head.
I'm not sure if using 'My Account' would work with i18n...
sdrozdsap
reviewed
Dec 19, 2024
| * Removes invalid aria-level usage on button elements and ensures buttons have a proper accessible name via aria-label or aria-labelledby. | ||
| * Affects: NavigationUIComponent | ||
| */ | ||
| a11yButtonAriaFixes?: boolean; |
There was a problem hiding this comment.
maybe we should be more specific like a11yNavigationButtonsAriaFixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets: CXSPA-8997, CXSPA-8998
Removes invalid aria-level usage on button elements and ensures buttons have a proper accessible name via aria-label or aria-labelledby.
Affects: NavigationUIComponent