Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: a11yPasswordVisibilityBtnValueOverflow typo (#19531)" #19756

Merged
merged 2 commits into from
Dec 10, 2024
+18 −16
Merged

revert: "fix: a11yPasswordVisibilityBtnValueOverflow typo (#19531)" #19756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b54dd2c
Revert "fix: a11yPasswordVisibilityBtnValueOverflow typo (#19531)"
Zeyber Dec 10, 2024
e6032e4
add to csagent
Zeyber Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature-libs/asm/components/csagent-login-form/csagent-login-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class CSAgentLoginFormComponent implements OnInit {
submitEvent = new EventEmitter<{ userId: string; password: string }>();

constructor(protected fb: UntypedFormBuilder) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
kpawelczak marked this conversation as resolved.
Show resolved Hide resolved
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
useFeatureStyles('a11yTextSpacingAdjustments');
}

Expand Down
2 changes: 1 addition & 1 deletion ...nents/order-confirmation/order-guest-register-form/order-guest-register-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class OrderGuestRegisterFormComponent implements OnDestroy {
protected authService: AuthService,
protected fb: UntypedFormBuilder
) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

submit() {
Expand Down
2 changes: 1 addition & 1 deletion ...dministration/components/user/change-password-form/user-change-password-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class UserChangePasswordFormComponent {
protected formService: UserChangePasswordFormService,
protected messageService: MessageService
) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

save(form: UntypedFormGroup): void {
Expand Down
2 changes: 1 addition & 1 deletion feature-libs/user/account/components/login-form/login-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { LoginFormComponentService } from './login-form-component.service';
})
export class LoginFormComponent {
constructor(protected service: LoginFormComponentService) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

form: UntypedFormGroup = this.service.form;
Expand Down
2 changes: 1 addition & 1 deletion feature-libs/user/account/components/otp-login-form/otp-login-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class OneTimePasswordLoginFormComponent {
@HostBinding('class.user-form') style = true;

constructor() {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

onSubmit(): void {
Expand Down
2 changes: 1 addition & 1 deletion feature-libs/user/profile/components/register/register.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export class RegisterComponent implements OnInit, OnDestroy {
protected authConfigService: AuthConfigService,
protected registerComponentService: RegisterComponentService
) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

ngOnInit() {
Expand Down
2 changes: 1 addition & 1 deletion feature-libs/user/profile/components/reset-password/reset-password.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class ResetPasswordComponent {
token$: Observable<string> = this.service.resetToken$;

constructor(protected service: ResetPasswordComponentService) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

onSubmit(token: string) {
Expand Down
2 changes: 1 addition & 1 deletion feature-libs/user/profile/components/update-email/update-email.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { UpdateEmailComponentService } from './update-email-component.service';
})
export class UpdateEmailComponent {
constructor(protected service: UpdateEmailComponentService) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

form: UntypedFormGroup = this.service.form;
Expand Down
2 changes: 1 addition & 1 deletion feature-libs/user/profile/components/update-password/my-account-v2-password.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class MyAccountV2PasswordComponent {
isUpdating$: Observable<boolean> = this.service.isUpdating$;

constructor() {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

onSubmit(): void {
Expand Down
2 changes: 1 addition & 1 deletion feature-libs/user/profile/components/update-password/update-password.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class UpdatePasswordComponent {
});

constructor(protected service: UpdatePasswordComponentService) {
useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow');
useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow');
}

form: UntypedFormGroup = this.service.form;
Expand Down
4 changes: 2 additions & 2 deletions projects/core/src/features-config/feature-toggles/config/feature-toggles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ export interface FeatureTogglesInterface {
/**
* Stops the inputs value from obstructing the 'PasswordVisibilityToggleComponent'.
*/
a11yPasswordVisibilityBtnValueOverflow?: boolean;
a11yPasswordVisibliltyBtnValueOverflow?: boolean;

/**
* In `ItemCounterComponenet`, Remove button no longer lose focus after activating when count is 2.
Expand Down Expand Up @@ -959,7 +959,7 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
a11yAddToWishlistFocus: false,
a11ySearchBoxFocusOnEscape: false,
a11yUpdatingCartNoNarration: false,
a11yPasswordVisibilityBtnValueOverflow: false,
a11yPasswordVisibliltyBtnValueOverflow: false,
a11yItemCounterFocus: false,
a11yScrollToReviewByShowReview: false,
a11yViewHoursButtonIconContrast: false,
Expand Down
2 changes: 1 addition & 1 deletion projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ if (environment.cpq) {
a11yAddToWishlistFocus: true,
a11ySearchBoxFocusOnEscape: true,
a11yUpdatingCartNoNarration: true,
a11yPasswordVisibilityBtnValueOverflow: true,
a11yPasswordVisibliltyBtnValueOverflow: true,
a11yItemCounterFocus: true,
a11yScrollToReviewByShowReview: true,
a11yViewHoursButtonIconContrast: true,
Expand Down
8 changes: 5 additions & 3 deletions projects/storefrontstyles/scss/cxbase/blocks/forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,8 +510,10 @@ form {
}

input[cxpasswordvisibilityswitch] {
@include forFeature('a11yPasswordVisibilityBtnValueOverflow') {
$password-visibility-btn-width: 30px;
padding-inline-end: calc($password-visibility-btn-width + $input-padding-x);
@include forFeature('a11yPasswordVisibliltyBtnValueOverflow') {
$password-visibbility-btn-width: 30px;
padding-inline-end: calc(
$password-visibbility-btn-width + $input-padding-x
);
}
}
Loading