fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL #19739

crisli001 · 2024-12-09T11:23:24Z

… for SPA UI

cypress · 2024-12-10T03:45:29Z

spartacus Run #46459

Run Properties: Passed #46459 • 804095d71f ℹ️: Merge cd3b128e51bf3eba3c8fb8c050c075ce5f9f5c3b into 3a234205e59792f259e103c3686d...

Project	`spartacus`
Branch Review	`bugfix/CXSPA-9098`
Run status	`Passed #46459`
Run duration	`03m 55s`
Commit	`804095d71f ℹ️: Merge cd3b128e51bf3eba3c8fb8c050c075ce5f9f5c3b into 3a234205e59792f259e103c3686d...`
Committer	`crisli001`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`125`
View all changes introduced in this branch ↗︎

github-actions · 2024-12-10T08:51:18Z

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

projects/core/src/occ/adapters/user/occ-customer-coupon.adapter.ts

projects/core/src/user/connectors/customer-coupon/customer-coupon.connector.ts

...s/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.html

...cts/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.ts

projects/storefrontlib/cms-components/myaccount/my-coupons/my-coupons.component.ts

github-actions · 2024-12-18T09:49:00Z

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

rmch91 · 2024-12-18T12:22:23Z

projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts

@@ -429,6 +429,7 @@ if (environment.cpq) {
        a11yWrapReviewOrderInSection: true,
        enableCarouselCategoryProducts: true,
        enableSecurePasswordValidation: true,
+        enableClaimCustomerCouponWithCodeInRequestBody: true,


That is true that we want to enable all toggles in our demo app, but in this exact case, if I understand correctly, the API will be available starting from some future version.
If yes - we toggle set to true, our e2e tests will be broken because this functionality will not work before the servers update.
In this case i think it should be false.
I also thinking, maybe it is good to add this information to the toggle JSdoc? Some info telling that if you enabling this toggle you should have cx in version FP8

Thanks, sorry for forget to tell you that we already integrated the new endpoints into Commerce since 2211.28, see following comment. And more details see https://sap-cx.slack.com/archives/C084MGZU2MP/p1733746463727399.

Ok, in this case it could be true, agree.
I run all e2e tests against your branch, and there are couple of e2e tests in different libs that start failing after this change.
Here you can check the result https://cloud.cypress.io/projects/k3nmep/runs/46437/overview?runStatus=FAILED&runStatus=CANCELLED&runStatus=ERRORED&runStatus=PASSED&runStatus=RUNNING&runStatus=NOTESTS&runStatus=TIMEDOUT&roarHideRunsWithDiffGroupsAndTags=1

The first one "Order history" is flaky and probably not related to your changes, it failed already earlier, but the other ones seems to be related to coupon.

Can you check it please on your side?

thanks, sure, will check and update

Hi @rmch91 , I have checked the failed cypress test cases except "Order history" which think not related my changes, yeah, the other failed cases is related with my changes, so I have updated the case with a little changes, now after update local running shows it is ok:

I have no access to trigger the whole e2e cypress tests, to see whether the fix(update) for failed test cases work or not, could you help re-run the whole e2e cypress tests based on the fix branch after the cases updated?
Thanks a lot.

Many thanks, I run it and waiting for the result

Two of them still failing

https://cloud.cypress.io/projects/k3nmep/runs/46446/overview?runStatus=FAILED&runStatus=CANCELLED&runStatus=ERRORED&runStatus=PASSED&runStatus=RUNNING&runStatus=NOTESTS&runStatus=TIMEDOUT&roarHideRunsWithDiffGroupsAndTags=1

...cts/storefrontapp-e2e-cypress/cypress/e2e/regression/coupons/my-coupons.e2e-spec-flaky.cy.ts

...s/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.html

rmch91 · 2024-12-18T12:52:37Z

Hi @crisli001. You add a comment for your toggle in feature-toggles.ts, there is nothing further you need to do for documentation. Thanks for asking 🙏

github-actions · 2024-12-19T06:04:14Z

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

crisli001 · 2024-12-19T07:07:06Z

Hi @rmch91, I have updated again, could you help review again? Thanks a lot.

cypress · 2024-12-19T12:40:48Z

spartacus Run #46460

Run Properties: Failed #46460 • cd3b128e51: Trigger Build

Project	`spartacus`
Branch Review	`bugfix/CXSPA-9098`
Run status	`Failed #46460`
Run duration	`13m 06s`
Commit	`cd3b128e51: Trigger Build`
Committer	`Cris Li`
View all properties for this run ↗︎

Test results
Failures	`3`
Flaky	`2`
Pending	`22`
Skipped	`0`
Passing	`811`
View all changes introduced in this branch ↗︎

Tests for review

regression/asm/customer360.e2e.cy.ts • 1 failed test • B2C

View Output Video

Test		Artifacts
Assisted Service Module > Promotion > should be able to remove customer coupon for customer coupon (CXSPA-3945)		`Test Replay` `Screenshots` `Video`

regression/multi-dimensional/multi-dimensional-checkout-as-guest.e2e.cy.ts • 1 failed test • B2C

View Output Video

Test		Artifacts
... > should perform checkout as guest, create an account and verify guest data, and verify cart persists after registering		`Test Replay` `Screenshots` `Video`

b2b/regression/asm/customer360-promotion.e2e.cy.ts • 1 failed test • B2B

View Output Video

Test		Artifacts
Assisted Service Module > B2B Asm Customer360 Promotion > should be able to remove customer coupon for customer coupon (CXSPA-3945)		`Test Replay` `Screenshots` `Video`

my-account/order-history-orders-flow.e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
Order History with orders > Mobile > should sort the orders table by given code		`Test Replay` `Screenshots` `Video`

redirects/auth-redirects.e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
Redirect after auth > should redirect back after the forced login when access token expired and page was refreshed		`Test Replay` `Screenshots` `Video`

github-actions · 2024-12-20T01:52:41Z

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

crisli001 · 2024-12-20T03:24:28Z

Hi @rmch91 , I have updated cypress test cases, could you help re-run the whole cypress tests and review the PR again?
Thanks a lot.

…into bugfix/CXSPA-9098

crisli001 added 7 commits December 9, 2024 18:30

CXSPA-9098, fix the issue Coupon Codes is used in Coupon Campaign URL…

7f6b77d

… for SPA UI

fix failed unit test

d4587da

fix failed unit test cases

9ba5cd1

fix sonar issues

5388aa2

fix sonar issues using const instead of let

967974e

fix code validation failed issues

bce0e55

do code format for the PR

31a383f

crisli001 marked this pull request as ready for review December 10, 2024 03:21

crisli001 requested review from a team as code owners December 10, 2024 03:21

crisli001 requested a review from ssisali December 10, 2024 03:22

Merge branch 'develop' into bugfix/CXSPA-9098

b3005d3

github-actions bot marked this pull request as draft December 10, 2024 07:46

crisli001 marked this pull request as ready for review December 10, 2024 08:37

Merge branch 'develop' into bugfix/CXSPA-9098

19f4cd7

github-actions bot marked this pull request as draft December 10, 2024 08:51

crisli001 marked this pull request as ready for review December 10, 2024 08:51

rmch91 requested changes Dec 17, 2024

View reviewed changes

crisli001 added 3 commits December 18, 2024 17:37

CXSPA-9098, fix breaking changes by add feature toggle and inject

7858833

CXSPA-9098, fix conflicts

1b7b8db

Merge branch 'develop' into bugfix/CXSPA-9098

3694d1b

github-actions bot marked this pull request as draft December 18, 2024 09:46

crisli001 marked this pull request as ready for review December 18, 2024 09:46

CXSPA-9098, fix module-import circular dependency

44dcf06

github-actions bot marked this pull request as draft December 18, 2024 09:58

crisli001 marked this pull request as ready for review December 18, 2024 09:58

crisli001 changed the title ~~CXSPA-9098, fix the issue Coupon Codes is used in Coupon Campaign URL…~~ fix: (CXSPA-9098)-fix the issue Coupon Codes is used in Coupon Campaign URL… Dec 18, 2024

crisli001 changed the title ~~fix: (CXSPA-9098)-the issue Coupon Codes is used in Coupon Campaign URL~~ fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL Dec 18, 2024

rmch91 requested changes Dec 18, 2024

View reviewed changes

CXSPA-9098, remove unnecessary feature toggle

d751b80

github-actions bot marked this pull request as draft December 19, 2024 05:48

Merge branch 'develop' into bugfix/CXSPA-9098

525940f

crisli001 marked this pull request as ready for review December 19, 2024 05:48

Trigger Build

c23b62d

github-actions bot marked this pull request as draft December 19, 2024 06:39

crisli001 marked this pull request as ready for review December 19, 2024 06:41

crisli001 requested a review from rmch91 December 19, 2024 07:26

CXSPA-9098, fix failed cypress test cases

4ad8cfe

github-actions bot marked this pull request as draft December 20, 2024 01:46

crisli001 marked this pull request as ready for review December 20, 2024 01:47

Merge branch 'develop' into bugfix/CXSPA-9098

4851cca

github-actions bot marked this pull request as draft December 20, 2024 01:52

crisli001 marked this pull request as ready for review December 20, 2024 02:00

Merge branch 'develop' into bugfix/CXSPA-9098

3687735

github-actions bot marked this pull request as draft December 22, 2024 06:22

crisli001 added 2 commits December 22, 2024 14:26

CXSPA-9098, try enhance case

0667bae

Merge branch 'bugfix/CXSPA-9098' of https://github.com/SAP/spartacus …

73c7b33

…into bugfix/CXSPA-9098

crisli001 marked this pull request as ready for review December 22, 2024 06:29

Trigger Build

cd3b128

github-actions bot marked this pull request as draft December 22, 2024 06:57

crisli001 marked this pull request as ready for review December 22, 2024 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL #19739

fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL #19739

crisli001 commented Dec 9, 2024

cypress bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 18, 2024

rmch91 Dec 18, 2024

crisli001 Dec 19, 2024 •

edited

Loading

rmch91 Dec 19, 2024

crisli001 Dec 20, 2024

crisli001 Dec 20, 2024 •

edited

Loading

rmch91 Dec 20, 2024

rmch91 Dec 20, 2024

rmch91 commented Dec 18, 2024

github-actions bot commented Dec 19, 2024

crisli001 commented Dec 19, 2024 •

edited

Loading

cypress bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024

crisli001 commented Dec 20, 2024

fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL #19739

Are you sure you want to change the base?

fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL #19739

Conversation

crisli001 commented Dec 9, 2024

cypress bot commented Dec 10, 2024 • edited Loading

spartacus Run #46459

github-actions bot commented Dec 10, 2024

Merge Checks Failed

github-actions bot commented Dec 18, 2024

Merge Checks Failed

rmch91 Dec 18, 2024

Choose a reason for hiding this comment

crisli001 Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

rmch91 Dec 19, 2024

Choose a reason for hiding this comment

crisli001 Dec 20, 2024

Choose a reason for hiding this comment

crisli001 Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

rmch91 Dec 20, 2024

Choose a reason for hiding this comment

rmch91 Dec 20, 2024

Choose a reason for hiding this comment

rmch91 commented Dec 18, 2024

github-actions bot commented Dec 19, 2024

Merge Checks Failed

crisli001 commented Dec 19, 2024 • edited Loading

cypress bot commented Dec 19, 2024 • edited Loading

spartacus Run #46460

Tests for review

github-actions bot commented Dec 20, 2024

Merge Checks Failed

crisli001 commented Dec 20, 2024

cypress bot commented Dec 10, 2024 •

edited

Loading

crisli001 Dec 19, 2024 •

edited

Loading

crisli001 Dec 20, 2024 •

edited

Loading

crisli001 commented Dec 19, 2024 •

edited

Loading

cypress bot commented Dec 19, 2024 •

edited

Loading