Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-9060) - Limit popover width on sub 375px devices #19683

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix: (CXSPA-9060) - Limit popover width on sub 375px devices #19683

merged 2 commits into from
Dec 3, 2024

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Dec 2, 2024

Closes: CXSPA-9060

@Pio-Bar Pio-Bar requested a review from a team as a code owner December 2, 2024 15:45
@github-actions github-actions bot marked this pull request as draft December 2, 2024 15:45
@Pio-Bar Pio-Bar marked this pull request as ready for review December 2, 2024 16:33
@cypress Cypress
Copy link

cypress bot commented Dec 2, 2024

spartacus    Run #46140

Run Properties:  status check passed Passed #46140  •  git commit 41d34c6282 ℹ️: Merge 0b0905599c8ad1d14b421fd54235e6474d038589 into a4b72abd137d8898669c4d830996...
Project spartacus
Branch Review feature/CXSPA-9060
Run status status check passed Passed #46140
Run duration 12m 59s
Commit git commit 41d34c6282 ℹ️: Merge 0b0905599c8ad1d14b421fd54235e6474d038589 into a4b72abd137d8898669c4d830996...
Committer PioBar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

developpeurweb
developpeurweb approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@developpeurweb developpeurweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pio-Bar let's deploy it to retest on real mobile device

@github-actions github-actions bot marked this pull request as draft December 3, 2024 21:26
@giancorderoortiz giancorderoortiz marked this pull request as ready for review December 3, 2024 21:40
@giancorderoortiz giancorderoortiz merged commit bb7b6af into develop Dec 3, 2024
28 checks passed
@giancorderoortiz giancorderoortiz deleted the feature/CXSPA-9060 branch December 3, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developpeurweb developpeurweb developpeurweb approved these changes

@Zeyber Zeyber Zeyber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pio-Bar @Zeyber @developpeurweb @giancorderoortiz