feat: (CXSPA-8988) - Add missing labels for Combo boxes in Order Summary #19659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-8988
|
| Run status |
|
| Run duration | 13m 34s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Pio-Bar
previously approved these changes
Nov 29, 2024
| <span *ngIf="isMonthly" class="form-data-label">{{ | ||
| 'checkoutScheduledReplenishment.every' | cxTranslate | ||
| }}</span> | ||
| <div *cxFeature="'!a11yScheduleReplenishment'"> |
There was a problem hiding this comment.
We can use <ng-container> to avoid the extra div
There was a problem hiding this comment.
I've just updated it.
Zeyber
requested changes
Nov 29, 2024
| </select> | ||
| <select | ||
| *cxFeature="'a11yScheduleReplenishment'" | ||
| id="order-replenishment-period-type" |
There was a problem hiding this comment.
We can introduce id attributes without a feature toggle because its not a breaking change.
There was a problem hiding this comment.
I've just updated it.
| </select> | ||
| <select | ||
| *cxFeature="'a11yScheduleReplenishment'" | ||
| id="order-replenishment-period-type" |
There was a problem hiding this comment.
We can introduce id attributes without a feature toggle because its not a breaking change.
There was a problem hiding this comment.
I've just updated it.
| </select> | ||
| <select | ||
| *cxFeature="'a11yScheduleReplenishment'" | ||
| id="order-replenishment-day-of-month" |
There was a problem hiding this comment.
We can introduce id attributes without a feature toggle because its not a breaking change.
There was a problem hiding this comment.
I've just updated it.
Zeyber
approved these changes
Dec 2, 2024
developpeurweb
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CXSPA-8988
Add missing labels for Combo boxes in Order Summary