Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-8015) improve tab focus visibility (show all four sides of focused ring) #19637

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

uroslates
Copy link
Contributor

@uroslates uroslates requested a review from a team as a code owner November 27, 2024 09:50
@github-actions github-actions bot marked this pull request as draft November 27, 2024 09:50
@uroslates uroslates marked this pull request as ready for review November 27, 2024 10:11
Copy link

cypress bot commented Nov 27, 2024

spartacus    Run #46004

Run Properties:  status check passed Passed #46004  •  git commit f0eba6fd98 ℹ️: Merge 94b0f9ccf502496277cd278be50a0336bdbb0d74 into 8702aa8e299fb8a360694ea87bfd...
Project spartacus
Branch Review feature/CXSPA-8015-post-review
Run status status check passed Passed #46004
Run duration 13m 56s
Commit git commit f0eba6fd98 ℹ️: Merge 94b0f9ccf502496277cd278be50a0336bdbb0d74 into 8702aa8e299fb8a360694ea87bfd...
Committer Uros Lates
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft November 27, 2024 16:12
@uroslates uroslates marked this pull request as ready for review November 27, 2024 16:20
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft November 27, 2024 16:28
@uroslates uroslates marked this pull request as ready for review November 27, 2024 16:30
@uroslates uroslates merged commit 44c66f4 into develop Nov 27, 2024
28 checks passed
@uroslates uroslates deleted the feature/CXSPA-8015-post-review branch November 27, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants