feat: (CXSPA-8032) - Change a into button for "Cancel Orders" and "Request a Return" #19306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 11m 36s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
Pio-Bar
requested changes
Oct 1, 2024
| @@ -10,7 +10,7 @@ | |||
| </div> | |||
|
|
|||
| <div class="col-xs-12 col-md-4 col-lg-3"> | |||
| <a | |||
| <button | |||
There was a problem hiding this comment.
I have just taken a look at the jira ticket. Miguel suggested using a role="button" attribute. This would be a better solution as its functionally still an anchor element. If we go this route we won't a feature flag too 🙂
There was a problem hiding this comment.
I've just updated it.
petarmarkov9449
changed the title
Merge Checks Failed |
Pio-Bar
requested changes
Oct 3, 2024
There was a problem hiding this comment.
We probably no longer need to modify the tests here 🙂
There was a problem hiding this comment.
I've just restored it.
Pio-Bar
approved these changes
Oct 7, 2024
Zeyber
approved these changes
Oct 8, 2024
developpeurweb
approved these changes
Oct 9, 2024
Merge Checks Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: CXSPA-8032
Back button was read as link. UI type read was incorrect.