-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/CXSPA-8061: S/4HANA Service Order UI - Alter Delivery Mode Tab in Checkout #19176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platonn
reviewed
Sep 10, 2024
integration-libs/s4-service/order/components/order-summary/service-details-card.module.ts
Outdated
Show resolved
Hide resolved
feature-libs/order/components/order-details/order-overview/order-overview-component.service.ts
Outdated
Show resolved
Hide resolved
integration-libs/s4-service/root/config/default-service-delivery-mode-config.ts
Outdated
Show resolved
Hide resolved
Platonn
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM with scope: shared / global things / architecture / standards
Please review and QA the feature details specifically within the Team Fusion. Thanks in advance!
spartacus Run #44804
Run Properties:
|
Project |
spartacus
|
Branch Review |
service-delivery-mode
|
Run status |
Passed #44804
|
Run duration | 13m 46s |
Commit |
18b2280481 ℹ️: Merge f626f141a0c7bdefeddb45b569b15fb1f7df9fa7 into afd0be433df41945d62ce5d28513...
|
Committer | anjana-bl |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
121
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Pio-Bar
pushed a commit
that referenced
this pull request
Sep 11, 2024
…n Checkout (#19176) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.tools.sap/browse/CXSPA-8061