Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2211.28.0-1 #19174

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Release 2211.28.0-1 #19174

merged 5 commits into from
Aug 28, 2024

Conversation

rmch91
Copy link
Contributor

@rmch91 rmch91 commented Aug 28, 2024

No description provided.

@rmch91 rmch91 requested review from a team as code owners August 28, 2024 12:51
@github-actions github-actions bot marked this pull request as draft August 28, 2024 12:51
@rmch91 rmch91 marked this pull request as ready for review August 28, 2024 12:51
Copy link

cypress bot commented Aug 28, 2024

spartacus    Run #44662

Run Properties:  status check passed Passed #44662  •  git commit 08cb3d6b42 ℹ️: Merge 464f0069585ecd041502888971fd56c0df83dcb3 into 780d582de7dbdf7edbcfe75bb21a...
Project spartacus
Branch Review release-2211.28.0-1
Run status status check passed Passed #44662
Run duration 04m 47s
Commit git commit 08cb3d6b42 ℹ️: Merge 464f0069585ecd041502888971fd56c0df83dcb3 into 780d582de7dbdf7edbcfe75bb21a...
Committer Roman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Aug 28, 2024

spartacus    Run #44664

Run Properties:  status check passed Passed #44664  •  git commit 464f006958: Merge remote-tracking branch 'origin/develop' into release-2211.28.0-1
Project spartacus
Branch Review release-2211.28.0-1
Run status status check passed Passed #44664
Run duration 12m 44s
Commit git commit 464f006958: Merge remote-tracking branch 'origin/develop' into release-2211.28.0-1
Committer rmch91
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 27
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 792
View all changes introduced in this branch ↗︎

@@ -28,7 +28,7 @@ import { peerDependencies } from '../../package.json';
const collectionPath = path.join(__dirname, '../collection.json');
const scssFilePath = 'src/styles/spartacus/product-configurator.scss';

describe('Spartacus product configurator schematics: ng-add', () => {
xdescribe('Spartacus product configurator schematics: ng-add', () => {
Copy link
Contributor

@pawelfras pawelfras Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query: is this change intentional?

@@ -25,7 +25,7 @@ import { peerDependencies } from '../../package.json';
const collectionPath = path.join(__dirname, '../collection.json');
const scssFilePath = 'src/styles/spartacus/product-multi-dimensional.scss';

describe('Spartacus Product Multi-Dimensional schematics: ng-add', () => {
xdescribe('Spartacus Product Multi-Dimensional schematics: ng-add', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query: is this change intentional?

@rmch91 rmch91 requested a review from pawelfras August 28, 2024 14:10
@kimhw0630 kimhw0630 merged commit 540869b into develop Aug 28, 2024
68 checks passed
@kimhw0630 kimhw0630 deleted the release-2211.28.0-1 branch August 28, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants