-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2211.28.0-1 #19174
Merged
Merged
Release 2211.28.0-1 #19174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus Run #44662
Run Properties:
|
Project |
spartacus
|
Branch Review |
release-2211.28.0-1
|
Run status |
Passed #44662
|
Run duration | 04m 47s |
Commit |
08cb3d6b42 ℹ️: Merge 464f0069585ecd041502888971fd56c0df83dcb3 into 780d582de7dbdf7edbcfe75bb21a...
|
Committer | Roman |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
4
|
Pending |
2
|
Skipped |
0
|
Passing |
121
|
View all changes introduced in this branch ↗︎ |
spartacus Run #44664
Run Properties:
|
Project |
spartacus
|
Branch Review |
release-2211.28.0-1
|
Run status |
Passed #44664
|
Run duration | 12m 44s |
Commit |
464f006958: Merge remote-tracking branch 'origin/develop' into release-2211.28.0-1
|
Committer | rmch91 |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
27
|
Skipped |
0
|
Passing |
792
|
View all changes introduced in this branch ↗︎ |
pawelfras
reviewed
Aug 28, 2024
@@ -28,7 +28,7 @@ import { peerDependencies } from '../../package.json'; | |||
const collectionPath = path.join(__dirname, '../collection.json'); | |||
const scssFilePath = 'src/styles/spartacus/product-configurator.scss'; | |||
|
|||
describe('Spartacus product configurator schematics: ng-add', () => { | |||
xdescribe('Spartacus product configurator schematics: ng-add', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query:
is this change intentional?
pawelfras
reviewed
Aug 28, 2024
@@ -25,7 +25,7 @@ import { peerDependencies } from '../../package.json'; | |||
const collectionPath = path.join(__dirname, '../collection.json'); | |||
const scssFilePath = 'src/styles/spartacus/product-multi-dimensional.scss'; | |||
|
|||
describe('Spartacus Product Multi-Dimensional schematics: ng-add', () => { | |||
xdescribe('Spartacus Product Multi-Dimensional schematics: ng-add', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query:
is this change intentional?
pawelfras
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.