-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a11y): Arrow keys navigation for carousel #19168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
August 27, 2024 20:20
9bdf963
to
42187c2
Compare
Merge Checks Failed
|
Merge Checks Failed
|
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
August 28, 2024 06:50
860d9bb
to
c83141d
Compare
Merge Checks Failed
|
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
August 28, 2024 06:58
dc77ccd
to
26367d3
Compare
Merge Checks Failed
|
spartacus Run #44854
Run Properties:
|
Project |
spartacus
|
Branch Review |
bugfix/CXSPA-7970
|
Run status |
Passed #44854
|
Run duration | 03m 58s |
Commit |
bfbeb12c4d ℹ️: Merge 7efa05d4b6b129e736a56fc4acd1818297d4f080 into d03a64a97aa9add2ff95fcbe50a0...
|
Committer | sdrozdsap |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
121
|
View all changes introduced in this branch ↗︎ |
Zeyber
requested changes
Sep 4, 2024
projects/storefrontlib/shared/components/carousel/carousel.component.ts
Outdated
Show resolved
Hide resolved
...tlib/shared/components/carousel/focusable-carousel-item/focusable-carousel-item.directive.ts
Show resolved
Hide resolved
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 5, 2024 09:35
2703585
to
9ad708d
Compare
Merge Checks Failed
|
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 5, 2024 09:36
7e6195b
to
d5f270b
Compare
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 12, 2024 07:15
20387e4
to
e977349
Compare
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 12, 2024 07:57
e977349
to
23025c4
Compare
Zeyber
previously approved these changes
Sep 12, 2024
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 12, 2024 11:58
23025c4
to
5485354
Compare
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 13, 2024 06:15
5485354
to
14829f0
Compare
sdrozdsap
dismissed stale reviews from developpeurweb and Zeyber
via
September 13, 2024 06:24
2b9b398
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 13, 2024 06:24
14829f0
to
2b9b398
Compare
Merge Checks Failed
|
sdrozdsap
force-pushed
the
bugfix/CXSPA-7970
branch
from
September 13, 2024 06:58
2b96c53
to
631d8a0
Compare
Merge Checks Failed
|
Zeyber
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://jira.tools.sap/browse/CXSPA-7970