Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-1128) - NgSelect double stop on mobile alternative fix #19152

Merged
merged 25 commits into from
Oct 10, 2024

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Aug 22, 2024

Ticket: CXSPA-1128

To avoid the console error the previous solution caused, we can hide the display value from the screen reader and instead provide it as a part of the aria-label. We can limit this solution to the mobile devices since the bug is only present for such.

I could not come up with a better solution that would satisfy the requirement. This feels a bit hacky to me, I would like @developpeurweb to share his opinion on this.

@Pio-Bar Pio-Bar requested a review from a team as a code owner August 22, 2024 15:34
@github-actions github-actions bot marked this pull request as draft August 22, 2024 15:34
@Pio-Bar Pio-Bar marked this pull request as ready for review August 22, 2024 15:34
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 23, 2024 07:28
@Pio-Bar Pio-Bar marked this pull request as ready for review August 23, 2024 07:28
Copy link

cypress bot commented Aug 23, 2024

spartacus    Run #45245

Run Properties:  status check passed Passed #45245  •  git commit ed8001ea28 ℹ️: Merge d21412553e6368e512ed11f853816a2daa587ffd into 2e61752ee14e67ba07dd0e94c657...
Project spartacus
Run status status check passed Passed #45245
Run duration 11m 19s
Commit git commit ed8001ea28 ℹ️: Merge d21412553e6368e512ed11f853816a2daa587ffd into 2e61752ee14e67ba07dd0e94c657...
Committer PioBar
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@github-actions github-actions bot marked this pull request as draft August 23, 2024 16:53
@Pio-Bar Pio-Bar marked this pull request as ready for review August 23, 2024 16:54
@github-actions github-actions bot marked this pull request as draft August 26, 2024 10:11
@Pio-Bar Pio-Bar marked this pull request as ready for review August 26, 2024 10:12
developpeurweb
developpeurweb previously approved these changes Aug 26, 2024
@Pio-Bar Pio-Bar marked this pull request as ready for review September 6, 2024 13:03
@github-actions github-actions bot marked this pull request as draft September 10, 2024 14:20
@Pio-Bar Pio-Bar marked this pull request as ready for review September 10, 2024 14:20
@github-actions github-actions bot marked this pull request as draft September 20, 2024 10:26
@Pio-Bar Pio-Bar marked this pull request as ready for review September 25, 2024 08:23
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft September 26, 2024 08:44
@Pio-Bar Pio-Bar marked this pull request as ready for review September 26, 2024 08:44
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft September 30, 2024 08:49
@Pio-Bar Pio-Bar marked this pull request as ready for review September 30, 2024 08:49
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 2, 2024 10:21
@Pio-Bar Pio-Bar marked this pull request as ready for review October 2, 2024 10:25
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 9, 2024 08:01
@Pio-Bar Pio-Bar dismissed stale reviews from developpeurweb and Zeyber via 5a72223 October 10, 2024 10:22
@Pio-Bar Pio-Bar marked this pull request as ready for review October 10, 2024 10:25
@github-actions github-actions bot marked this pull request as draft October 10, 2024 11:53
@Pio-Bar Pio-Bar marked this pull request as ready for review October 10, 2024 12:10
@Pio-Bar Pio-Bar merged commit ec946e9 into develop Oct 10, 2024
28 checks passed
@Pio-Bar Pio-Bar deleted the bugfix/CXSPA-1128 branch October 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants