-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (CXSPA-1128) - NgSelect double stop on mobile alternative fix #19152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Checks Failed
|
spartacus Run #45245
Run Properties:
|
Project |
spartacus
|
Run status |
Passed #45245
|
Run duration | 11m 19s |
Commit |
ed8001ea28 ℹ️: Merge d21412553e6368e512ed11f853816a2daa587ffd into 2e61752ee14e67ba07dd0e94c657...
|
Committer | PioBar |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
125
|
Upgrade your plan to view test results. |
developpeurweb
previously approved these changes
Aug 26, 2024
Zeyber
requested changes
Sep 3, 2024
projects/storefrontlib/shared/components/ng-select-a11y/ng-select-a11y.directive.ts
Outdated
Show resolved
Hide resolved
projects/storefrontlib/shared/components/ng-select-a11y/ng-select-a11y.directive.ts
Show resolved
Hide resolved
Zeyber
requested changes
Sep 12, 2024
projects/storefrontlib/shared/components/ng-select-a11y/ng-select-a11y.directive.ts
Outdated
Show resolved
Hide resolved
Zeyber
requested changes
Sep 19, 2024
projects/storefrontlib/shared/components/ng-select-a11y/ng-select-a11y.directive.ts
Outdated
Show resolved
Hide resolved
Merge Checks Failed
|
Merge Checks Failed
|
Merge Checks Failed
|
Merge Checks Failed
|
Zeyber
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-1128
To avoid the console error the previous solution caused, we can hide the display value from the screen reader and instead provide it as a part of the aria-label. We can limit this solution to the mobile devices since the bug is only present for such.
I could not come up with a better solution that would satisfy the requirement. This feels a bit hacky to me, I would like @developpeurweb to share his opinion on this.