Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CXSPA-7900 Ajust schematics to enable option in fresh apps #19055

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

pawelfras
Copy link
Contributor

PR contains a small adjustment to schematics that enables avoidCachingErrors optimization option in a fresh application to avoid tech debt.

QA steps:

  • build and deploy Spartacus packages locally:
    npx ts-node ./tools/schematics/testing.ts in the SPA root folder`
  • create new app npx @angular/cli@17 new my-app --standalone=false --style=scss --routing=false
  • go to the project's directory and install Spartacus from local packages:
    npx @angular/cli@17 add @spartacus/schematics@latest --ssr --baseUrl="https://40.76.109.9:9002"
  • check in server.ts whether avoidCachingErrors has been added:
    const ngExpressEngine = NgExpressEngineDecorator.get(engine, {
      avoidCachingErrors: true, // takes effect only when cache is enabled
    });
    

closes CXSPA-7900

@pawelfras pawelfras requested a review from a team as a code owner July 17, 2024 12:17
Copy link
Contributor

@Platonn Platonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise

@pawelfras pawelfras merged commit a1979bc into epic/ssr-error-handling Jul 23, 2024
11 checks passed
@pawelfras pawelfras deleted the feat/CXSPA-7900 branch July 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants