Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix sonar issues #19011

Merged
merged 7 commits into from
Jun 28, 2024
Merged

fix: Fix sonar issues #19011

merged 7 commits into from
Jun 28, 2024

Conversation

rmch91
Copy link
Contributor

@rmch91 rmch91 commented Jun 27, 2024

@rmch91 rmch91 requested a review from a team as a code owner June 27, 2024 11:48
@github-actions github-actions bot marked this pull request as draft June 27, 2024 11:48
@rmch91 rmch91 marked this pull request as ready for review June 27, 2024 11:49
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft June 27, 2024 12:05
@rmch91 rmch91 marked this pull request as ready for review June 27, 2024 13:31
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft June 27, 2024 13:47
@rmch91 rmch91 marked this pull request as ready for review June 27, 2024 13:48
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft June 27, 2024 14:03
@rmch91 rmch91 marked this pull request as ready for review June 27, 2024 14:12
@RadhepS
Copy link
Contributor

RadhepS commented Jun 27, 2024

Hey I noticed there's an e2e failure, can you verify whether it's related?

Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft June 27, 2024 20:23
@rmch91 rmch91 marked this pull request as ready for review June 27, 2024 20:23
Copy link

cypress bot commented Jun 27, 2024

3 flaky tests on run #44169 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge 048a441 into e543cfa...
Project: spartacus Commit: e7784b3e86 ℹ️
Status: Passed Duration: 03:55 💡
Started: Jun 27, 2024 9:01 PM Ended: Jun 27, 2024 9:04 PM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #19011 ↗︎

@github-actions github-actions bot marked this pull request as draft June 27, 2024 20:51
@rmch91 rmch91 marked this pull request as ready for review June 27, 2024 20:51
@rmch91 rmch91 merged commit 2c46b37 into develop Jun 28, 2024
28 checks passed
@rmch91 rmch91 deleted the fix/CXSPA-7747 branch June 28, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants