Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test check workflow execution #19008

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core-libs/setup/ssr/express-utils/express-request-url.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
import { Request } from 'express';
import { getRequestOrigin } from './express-request-origin';

/**
* @deprecated i don't know
*/
export function getRequestUrl(req: Request): string {
return getRequestOrigin(req) + req.originalUrl;
}
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,20 @@ export class ConfiguratorCartService {
new ConfiguratorActions.RemoveCartBoundConfigurations()
);
}

/**
* @deprecated
*/
protected isConfigurationCreated(
configuration: Configurator.Configuration
): boolean {
const configId: String = configuration.configId;
return configId.length !== 0;
}

/**
* @deprecated Use different instead of this
* Remove all configurations that are linked to cart entries
*/
protected configurationNeedsReading(
configurationState: StateUtils.LoaderState<Configurator.Configuration>
): boolean {
Expand Down
5 changes: 4 additions & 1 deletion projects/core/src/cms/page/base-page-meta.resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import { Injectable } from '@angular/core';
import { NavigationEnd, Router } from '@angular/router';
import { combineLatest, defer, Observable } from 'rxjs';
import { Observable, combineLatest, defer } from 'rxjs';
import { filter, map, shareReplay, startWith } from 'rxjs/operators';
import { TranslationService } from '../../i18n/translation.service';
import { CmsService } from '../facade/cms.service';
Expand All @@ -22,6 +22,9 @@ import {
import { PageLinkService } from './routing/page-link.service';
import { RoutingPageMetaResolver } from './routing/routing-page-meta.resolver';

/**
* @deprecated since 2024
*/
@Injectable({
providedIn: 'root',
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ export class GlobalMessageEffect {
)
);

/**
* @deprecated since 2211.24. Will be removed in 2211.35. Thats all for today
*/
hideAfterDelay$:
| Observable<GlobalMessageActions.RemoveMessage>
| (() => Observable<never>) = createEffect(() =>
Expand Down
Loading