fix: workaround for the features option schematics error #18923
Conversation
| export function getFeaturesOptions<OPTIONS extends LibraryOptions>( | ||
| options: OPTIONS | ||
| ): string[] { | ||
| return getArrayOptions(options.features ?? []); | ||
| } |
There was a problem hiding this comment.
nitpick: Did you consider having a different signature of this util function?
Now we use it as:
options.features = getFeaturesOptions(options);, where getFeaturesOptions is a pure function that knows about the shape of OPTIONS
IMHO more semantic would be using it as:
a) options.features = convertToArray(options.features), where convertToArray is a pure function, which doesn't know about the shape of the OPTIONS object
OR
b) normalizeOptionsFeatures(options) which under the hood mutates the options.features property
Personally, I tend toward the option a)
There was a problem hiding this comment.
Thanks, I went with option B as I think it will work better with JSDoc.
| } else if (values.includes(',')) { | ||
| optionsArray = values.split(','); |
There was a problem hiding this comment.
Question: shall we somehow trim whitespaces, if using as --features="Cart, Order, Checkout" (with spaces)?
- we should test it manually, if it works now (wihtout trimming)
- if it doesn't work with spaces, then let's fix it + add unit tests for this case
There was a problem hiding this comment.
My initial thought was that the correct command is --features=Cart,Order,Checkout, as this is the syntax used for an array-type option. The command you provided assumes that the feature is a string. However, the type array | string is just a workaround. I believe we should still treat it as an array.
I haven't tested the whitespace theory yet.
|
After a review and testing, we found that this workaround is not viable as it disrupts the prompts |
closes: CXSPA-7456
This pull request addresses the issue detailed in Angular CLI GitHub issue #16320. The problem is that using ng add with options of type array may not function correctly in some cases, and might only work on the second attempt.
To resolve this, we have implemented a workaround in the form of a new utility function, getFeaturesOptions. This function ensures that feature options are handled correctly, mitigating the problem described in the issue.
Changes:
getFeaturesOptionsfunction to work around the issue with ng add and array options.