Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-939) - Buttons should be triggered by space and enter #18740

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

sdrozdsap
Copy link
Contributor

No description provided.

@sdrozdsap sdrozdsap requested a review from a team as a code owner April 18, 2024 08:02
@github-actions github-actions bot marked this pull request as draft April 18, 2024 08:03
@sdrozdsap sdrozdsap marked this pull request as ready for review April 18, 2024 08:06
@github-actions github-actions bot marked this pull request as draft April 18, 2024 08:15
@sdrozdsap sdrozdsap marked this pull request as ready for review April 18, 2024 08:16
Copy link

cypress bot commented Apr 18, 2024

3 flaky tests on run #43389 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge 4c547ff into 106f393...
Project: spartacus Commit: 12f6dc9d3d ℹ️
Status: Passed Duration: 03:50 💡
Started: Apr 25, 2024 7:54 AM Ended: Apr 25, 2024 7:58 AM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #18740 ↗︎

@github-actions github-actions bot marked this pull request as draft April 22, 2024 08:40
@sdrozdsap sdrozdsap marked this pull request as ready for review April 22, 2024 08:41
@sdrozdsap sdrozdsap requested a review from Zeyber April 22, 2024 08:41
@github-actions github-actions bot marked this pull request as draft April 22, 2024 12:10
@sdrozdsap sdrozdsap marked this pull request as ready for review April 22, 2024 12:10
@sdrozdsap sdrozdsap requested a review from Zeyber April 22, 2024 12:10
@github-actions github-actions bot marked this pull request as draft April 25, 2024 07:03
@sdrozdsap sdrozdsap marked this pull request as ready for review April 25, 2024 07:03
@github-actions github-actions bot marked this pull request as draft April 25, 2024 07:44
@sdrozdsap sdrozdsap marked this pull request as ready for review April 25, 2024 07:45
@sdrozdsap sdrozdsap merged commit 88a26ac into develop Apr 25, 2024
26 checks passed
@sdrozdsap sdrozdsap deleted the bugfix/CXSPA-939 branch April 25, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants