Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-1054) - Provide more meaningful placeholder for apt number #18728

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: (CXSPA-1054) - Provide more meaningful placeholder for apt number #18728

merged 1 commit into from
Apr 18, 2024

Conversation

sdrozdsap
Copy link
Contributor

image

@sdrozdsap sdrozdsap requested review from a team as code owners April 15, 2024 09:49
@github-actions github-actions bot marked this pull request as draft April 15, 2024 09:50
@sdrozdsap sdrozdsap marked this pull request as ready for review April 15, 2024 09:50
@cypress Cypress
Copy link

cypress bot commented Apr 15, 2024 •
edited
Loading

4 flaky tests on run #43332 ↗︎

0 119 2 0 Flakiness 4

Details:

Merge 0fe704c into 0e1264e...
Project: spartacus Commit: 827da314b2 ℹ️
Status: Passed Duration: 03:58 💡
Started: Apr 18, 2024 7:22 AM Ended: Apr 18, 2024 7:26 AM
Flakiness  regression/variants/apparel-checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Apparel - checkout flow > Mobile > should perform checkout with a registered user Test Replay Screenshots Video
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #18728 ↗︎

@github-actions github-actions bot marked this pull request as draft April 18, 2024 07:13
@sdrozdsap sdrozdsap marked this pull request as ready for review April 18, 2024 07:13
@sdrozdsap sdrozdsap merged commit b416263 into develop Apr 18, 2024
26 checks passed
@sdrozdsap sdrozdsap deleted the bugfix/CXSPA-1054 branch April 18, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developpeurweb developpeurweb developpeurweb approved these changes

@Zeyber Zeyber Zeyber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdrozdsap @Zeyber @developpeurweb