Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CXSPA-6438 Add isPlatformBrowser check before OAuth initialization #18620

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix: CXSPA-6438 Add isPlatformBrowser check before OAuth initialization #18620

merged 2 commits into from
Mar 12, 2024

Conversation

rmch91
Copy link
Contributor

@rmch91 rmch91 commented Mar 12, 2024

@rmch91 rmch91 requested a review from a team as a code owner March 12, 2024 10:57
@github-actions github-actions bot marked this pull request as draft March 12, 2024 10:57
@rmch91 rmch91 marked this pull request as ready for review March 12, 2024 10:57
@cypress Cypress
Copy link

cypress bot commented Mar 12, 2024 •
edited
Loading

4 flaky tests on run #42916 ↗︎

0 119 2 0 Flakiness 4

Details:

Merge 8ab9444 into 8719a7d...
Project: spartacus Commit: 842d30483e ℹ️
Status: Passed Duration: 04:13 💡
Started: Mar 12, 2024 1:24 PM Ended: Mar 12, 2024 1:29 PM
Flakiness  regression/checkout/checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Checkout flow > Desktop > should checkout with a registered user by searching a product Test Replay Screenshots Video
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #18620 ↗︎

@github-actions github-actions bot marked this pull request as draft March 12, 2024 13:15
@rmch91 rmch91 marked this pull request as ready for review March 12, 2024 13:15
@rmch91 rmch91 merged commit b95a6f5 into release-2211.20.1 Mar 12, 2024
26 checks passed
@rmch91 rmch91 deleted the fix/CXSPA-6438 branch March 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Platonn Platonn Platonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmch91 @Platonn